enh: style cleanup (#772)

* enh: style cleanup

* enh: donate button

* enh: cards smaller

* enh: holy hell css overrides

* Update _data/contributors.yml

Author: lwasser

_data/contributors.yml

@@ -134,7 +134,7 @@
   github_username: willingc
   github_image_id: 2680980
   title: Advisory Council
-  sort:
+  sort: 2
   bio: Project Jupyter, nteract, and CPython core developer@python | @jupyter
       | @jupyterhub | @ipython | @nteract | @pysplash
   organization: Willing Consulting
@@ -262,7 +262,7 @@
   github_username: InessaPawson
   github_image_id: 43481325
   title: Advisory Council
-  sort:
+  sort: 1
   bio: NumPy Contributor Experience LeadOpen Source Program Manager at
       OpenTeams Incubator
   organization: '@numpy'
@@ -324,7 +324,7 @@
   title:
     - Advisory Council
     - Emeritus editor
-  sort: 2
+  sort:
   bio: Open Source Developer
   organization: xmnlab
   date_added: '2019-10-15'
@@ -369,7 +369,7 @@
   title:
     - Advisory Council
     - Editor
-  sort: 2
+  sort:
   bio: Filipe Fernandes is a Physical oceanographer by training, turned
       research software engineer, and a software packager hobbyist.
   organization:
@@ -495,7 +495,7 @@
   github_username: yuvipanda
   github_image_id: 30430
   title: Advisory Council
-  sort:
+  sort: 2
   bio:
   organization: '@2i2c-org'
   date_added: '2023-01-18'
@@ -527,7 +527,7 @@
   github_username: cmillion
   github_image_id: 1483210
   title: Advisory Council
-  sort:
+  sort: 0
   bio:
   organization:
   date_added: '2023-11-20'
@@ -643,15 +643,15 @@
   github_image_id: 1662261
   title:
     - Emeritus Editor in Chief
-    - Editor
+    - Emeritus Editor
     - Peer review triage
-  sort: 2
+  sort:
   bio:
   organization:
   date_added: '2023-01-24'
   deia_advisory: false
-  editorial_board: true
-  emeritus_editor: false
+  editorial_board: false
+  emeritus_editor: true
   advisory: false
   emeritus_advisory: false
   twitter:
@@ -803,14 +803,14 @@
   github_image_id: 11004857
   title:
     - Emeritus Editor in Chief
-    - Editor
+    - EmeritusEditor
   sort: 2
   bio:
   organization:
   date_added: '2023-02-04'
   deia_advisory: false
-  editorial_board: true
-  emeritus_editor: false
+  editorial_board: false
+  emeritus_editor: true
   advisory: false
   emeritus_advisory: false
   twitter:
@@ -4395,9 +4395,10 @@
   github_username: eliotwrobson
   github_image_id: 1345068
   title:
+    - Peer Review Lead
     - Editor
     - Emeritus Editor in Chief
-  sort: 1
+  sort: 0
   bio: I'm just this guy, you know?
   organization: UIUC
   date_added: '2023-09-11'
@@ -5405,7 +5406,7 @@
   title:
     - Editor
     - Editor in Chief
-  sort: 0
+  sort: 1
   bio:
   organization:
   date_added: '2023-12-21'

_data/navigation.yml

@@ -56,6 +56,6 @@ main:
     sub-nav:
       - title: "Volunteer"
         url: "/volunteer.html"
-      - title: "Donate"
-        icon: "fas fa-external-link-alt"
-        url: "https://fnd.us/pyopensci_2024"
+  - title: "Donate"
+    url: "https://fnd.us/pyopensci_2024"
+    is_button: true

_includes/masthead.html

@@ -17,7 +17,8 @@
         {% if alink.sub-nav %}
           <li class="dropdown">
             <button class="dropbtn" tabindex="0" aria-expanded="false">
-              {{ alink.title }} <i class="fas fa-caret-down"></i>
+              <span class="dropbtn-text">{{ alink.title }}</span>
+              <i class="fas fa-caret-down dropbtn-arrow"></i>
             </button>
             <ul class="dropdown-content">
               {% for subnav in alink.sub-nav %}
@@ -34,6 +35,12 @@
               {% endfor %}
             </ul>
           </li>
+        {% elsif alink.is_button %}
+          <li>
+            <a href="{{ alink.url }}" class="btn btn--primary donate-btn" target="_blank" rel="noopener noreferrer">
+              {{ alink.title }}
+            </a>
+          </li>
         {% else %}
           <li>
             <a href="{{ alink.url | relative_url }}" class="hover-underline">

_pages/contributors.md

@@ -22,7 +22,7 @@ by an expert team of volunteer advisory members who help steer the direction of
 
 {% assign advisory_sorted = site.data.contributors | where:"board",true | sort: 'sort' %}
 
-<div class="grid">
+<div class="grid executive-council-grid">
 {% for aperson in advisory_sorted %}
   {% include people-grid.html  %}
 {% endfor %}
@@ -39,14 +39,14 @@ pyOpenSci advisory council members are volunteer experts in the scientific
 Python open source space who provide high-level guidance on the development of
 the organization.
 
-{% assign advisory_working = site.data.contributors | where:"advisory",true | sort: 'sort' %}
+{% assign advisory_unsorted = site.data.contributors | where:"advisory",true %}
+{% assign advisory_with_sort = advisory_unsorted | where_exp:"item","item.sort != nil" | sort: 'sort' %}
+{% assign advisory_without_sort = advisory_unsorted | where_exp:"item","item.sort == nil" %}
+{% assign advisory_working = advisory_with_sort | concat: advisory_without_sort %}
 
-<div class="grid">
+<div class="grid advisory-council-grid">
 {% for aperson in advisory_working %}
-  {% if aperson.advisory %}
-  {{ aperson.person_name }}
-    {% include people-grid.html  %}
- {% endif %}
+  {% include people-grid.html  %}
 {% endfor %}
 </div>
 
@@ -61,7 +61,7 @@ leadership councils.
 
 {% assign emeritus_advisory = site.data.contributors | where:"emeritus_advisory", true %}
 
-<div class="grid">
+<div class="grid emeritus-council-grid">
 {% for aperson in emeritus_advisory %}
   {{ aperson.person_name }}
     {% include people-grid.html  %}
@@ -77,12 +77,11 @@ leadership councils.
 {: .clearall }
 {: .clearall }
 
-{% assign editorial = site.data.contributors | where:"editorial_board", true %}
+{% assign editorial = site.data.contributors | where:"editorial_board", true | sort: 'sort' %}
 
-<div class="grid">
+<div class="grid advisory-council-grid">
 {% for aperson in editorial %}
-  {{ aperson.person_name }}
-    {% include people-grid.html  %}
+  {% include people-grid.html  %}
 {% endfor %}
 </div>
 

_pages/volunteer.md

@@ -118,7 +118,7 @@ pyOpenSci has a diverse and vibrant community of pythonistas! To date,
 **{{ total_people }}** wonderful people have contributed to pyOpenSci.
 
 <div class="entries-grid">
-{% for aperson in new_ppl limit:4 %}
+{% for aperson in new_ppl limit:3 %}
     {% include people-grid.html  %}
 {% endfor %}
 </div>

_sass/minimal-mistakes/_archive.scss

@@ -65,17 +65,19 @@
 /* remove border*/
 .page__content {
   .archive__item-title {
-    //margin-top: 1em;
     border-bottom: none;
   }
 }
 
 .archive__item-excerpt {
   margin-top: 0;
+  margin-bottom: 0;
   font-size: $type-size-5;
 
   p {
     max-width: 95%;
+    margin-top: 0;
+    margin-bottom: 0;
   }
 
   & + p {
@@ -248,8 +250,19 @@ h2.archive__item-title {
 
 .feature__wrapper {
   @include clearfix();
-  margin-bottom: .02em; //used to be 2em
-  // border-bottom: 1px solid $border-color;
+  margin-bottom: 0.5em;
+  margin-top: 0.5em;
+
+  // Further reduce spacing when followed by pyos-section
+  + .pyos-section {
+    margin-top: 0;
+    padding-top: 0;
+  }
+
+  // Reduce spacing when it's the first element after header
+  .page__content > &:first-child {
+    margin-top: 0.5em;
+  }
 
   h2 {
     max-width: 100%;
@@ -258,6 +271,17 @@ h2.archive__item-title {
   .archive__item-title {
     margin-bottom: 0;
   }
+
+  // Reduce spacing for centered feature items (excerpts)
+  .feature__item--center {
+    margin-top: 0;
+    margin-bottom: 0;
+
+    .archive__item-excerpt {
+      margin-top: 0;
+      margin-bottom: 0;
+    }
+  }
 }
 
 .feature__item {
@@ -398,16 +422,27 @@ h2.archive__item-title {
     width: 100%;
     clear: both;
     font-size: 1.125em;
+    margin-top: 0;
+    margin-bottom: 0;
 
     .archive__item {
       float: left;
       width: 100%;
+      margin: 0;
+      padding: 0;
     }
 
     .archive__item-teaser {
       margin-bottom: 2em;
     }
 
+    .archive__item-body {
+      margin-top: 0;
+      margin-bottom: 0;
+      padding-top: 0;
+      padding-bottom: 0;
+    }
+
     a.btn::before {
       content: '';
       position: absolute;