Skip to content

Commit b969d04

Browse files
authored
enh(cleanup): Fix landing page cards and cleanup footer and styles (#774)
* enh: fix people cards on landing and volunteer pages * enh: card size * enh(refactor): refactor styles to separate concerns and use variables * enh: remove socials we don't use * enh: remove theme styles and cleanup footer
1 parent 6e62b1c commit b969d04

21 files changed

+140
-597
lines changed

_data/ui-text.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ en: &DEFAULT_EN
2323
comments_title : "Comments"
2424
more_label : "Learn more"
2525
related_label : "You may also enjoy"
26-
follow_label : "Connect:"
26+
follow_label : ""
2727
feed_label : "Feed"
2828
powered_by : "Powered by"
2929
website_label : "Website"

_includes/author-profile.html

Lines changed: 0 additions & 40 deletions
Original file line numberDiff line numberDiff line change
@@ -56,14 +56,6 @@ <h3 class="author__name p-name" itemprop="name">
5656
</li>
5757
{% endif %}
5858

59-
{% if author.keybase %}
60-
<li>
61-
<a href="https://keybase.io/{{ author.keybase }}" itemprop="sameAs" rel="nofollow noopener noreferrer me">
62-
<i class="fab fa-fw fa-keybase" aria-hidden="true"></i><span class="label">Keybase</span>
63-
</a>
64-
</li>
65-
{% endif %}
66-
6759
{% if author.twitter %}
6860
<li>
6961
<a href="https://twitter.com/{{ author.twitter }}" itemprop="sameAs" rel="nofollow noopener noreferrer me">
@@ -88,14 +80,6 @@ <h3 class="author__name p-name" itemprop="name">
8880
</li>
8981
{% endif %}
9082

91-
{% if author.xing %}
92-
<li>
93-
<a href="https://www.xing.com/profile/{{ author.xing }}" itemprop="sameAs" rel="nofollow noopener noreferrer me">
94-
<i class="fab fa-fw fa-xing-square" aria-hidden="true"></i><span class="label">XING</span>
95-
</a>
96-
</li>
97-
{% endif %}
98-
9983
{% if author.instagram %}
10084
<li>
10185
<a href="https://instagram.com/{{ author.instagram }}" itemprop="sameAs" rel="nofollow noopener noreferrer me">
@@ -112,14 +96,6 @@ <h3 class="author__name p-name" itemprop="name">
11296
</li>
11397
{% endif %}
11498

115-
{% if author.bitbucket %}
116-
<li>
117-
<a href="https://bitbucket.org/{{ author.bitbucket }}" itemprop="sameAs" rel="nofollow noopener noreferrer me">
118-
<i class="fab fa-fw fa-bitbucket" aria-hidden="true"></i><span class="label">Bitbucket</span>
119-
</a>
120-
</li>
121-
{% endif %}
122-
12399
{% if author.github %}
124100
<li>
125101
<a href="https://github.com/{{ author.github }}" itemprop="sameAs" rel="nofollow noopener noreferrer me">
@@ -152,14 +128,6 @@ <h3 class="author__name p-name" itemprop="name">
152128
</li>
153129
{% endif %}
154130

155-
{% if author.dribbble %}
156-
<li>
157-
<a href="https://dribbble.com/{{ author.dribbble }}" itemprop="sameAs" rel="nofollow noopener noreferrer me">
158-
<i class="fab fa-fw fa-dribbble" aria-hidden="true"></i><span class="label">Dribbble</span>
159-
</a>
160-
</li>
161-
{% endif %}
162-
163131
{% if author.pinterest %}
164132
<li>
165133
<a href="https://www.pinterest.com/{{ author.pinterest }}" itemprop="sameAs" rel="nofollow noopener noreferrer me">
@@ -168,14 +136,6 @@ <h3 class="author__name p-name" itemprop="name">
168136
</li>
169137
{% endif %}
170138

171-
{% if author.foursquare %}
172-
<li>
173-
<a href="https://foursquare.com/{{ author.foursquare }}" itemprop="sameAs" rel="nofollow noopener noreferrer me">
174-
<i class="fab fa-fw fa-foursquare" aria-hidden="true"></i><span class="label">Foursquare</span>
175-
</a>
176-
</li>
177-
{% endif %}
178-
179139
{% if author.steam %}
180140
<li>
181141
<a href="https://steamcommunity.com/id/{{ author.steam }}" itemprop="sameAs" rel="nofollow noopener noreferrer me">

_includes/footer.html

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,10 +23,9 @@
2323
</div>
2424

2525
<div class="page__footer-copyright">
26-
<p>pyOpenSci is a fiscally sponsored project of <a href="https://communityinitiatives.org/" target="_blank">Community Initiatives</a>, a registered 501(c)3 non-profit organization based in California, USA.
27-
pyOpenSci is grateful for support from the <a href="https://sloan.org/" target="_blank">Sloan Foundation</a> and the <a href="https://chanzuckerberg.com/" target="_blank">Chan Zuckerberg Initiative</a>.
28-
</p>
2926
<p>pyOpensci is dedicated to creating a welcoming, supportive and diverse community around the open source Python tools that drive open science. Our <a href="https://www.pyopensci.org/handbook/CODE_OF_CONDUCT.html" target="_blank">Code of Conduct</a> defines expected behavior and guidelines that help create such a community.
27+
pyOpenSci is a fiscally sponsored project of <a href="https://communityinitiatives.org/" target="_blank">Community Initiatives</a>, a registered 501(c)3 non-profit organization based in California, USA.
28+
pyOpenSci is grateful for support from the <a href="https://sloan.org/" target="_blank">Sloan Foundation</a> and the <a href="https://chanzuckerberg.com/" target="_blank">Chan Zuckerberg Initiative</a>.
3029
</p>
3130

3231
&copy; {{ site.time | date: '%Y' }} {{ site.name | default: site.title }}</div>

_includes/package-grid.html

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,12 @@
1+
{% assign use_isotope = include.isotope | default: false %}
2+
3+
{% if use_isotope %}
14
<div class="element-item package-card {% for aCategory in apackage.categories %}
25
{{ aCategory }}
36
{% endfor %}" data-category="data">
7+
{% else %}
8+
<div class="package-card">
9+
{% endif %}
410
<div class="package-card__content">
511
<h3 class="package-card__title" itemprop="name">
612
{{ apackage.package_name }}

_pages/home.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -134,7 +134,7 @@ peer-review:
134134

135135
{% assign packages_sorted = site.data.packages | sort_natural: 'date_accepted' | reverse %}
136136

137-
<div class="grid">
137+
<div class="packages-grid">
138138
{% for apackage in packages_sorted limit:3 %}
139139
{% include package-grid.html %}
140140
{% endfor %}

_pages/python-packages.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ To view packages affiliated with our partner communities that are a part of ourp
5151
<div class="grid-sizer"></div>
5252
{% for apackage in packages_sorted %}
5353
{% if apackage.active == true %}
54-
{% include package-grid.html %}
54+
{% include package-grid.html isotope=true %}
5555
{% endif %}
5656
{% endfor %}
5757
</div>
@@ -65,7 +65,7 @@ Archived packages are packages that have successfully completed [pyOpenSci's sof
6565
<div class="grid-sizer"></div>
6666
{% for apackage in packages_sorted %}
6767
{% if apackage.active == false %}
68-
{% include package-grid.html %}
68+
{% include package-grid.html isotope=true %}
6969
{% endif %}
7070
{% endfor %}
7171
</div>

_sass/minimal-mistakes/_footer.scss

Lines changed: 47 additions & 61 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717
background-color: darken($pyos-deeppurple, 8%);
1818
font-size: 0.85rem;
1919
line-height: 1.3rem;
20+
font-family: "Poppins", $sans-serif;
2021

2122
footer {
2223
@include clearfix;
@@ -50,11 +51,14 @@
5051
}
5152

5253
.page__footer-copyright {
53-
font-family: $global-font-family;
54+
font-family: "Poppins", $sans-serif;
5455
font-size: $type-size-6;
56+
padding: 1em;
57+
max-width: 900px;
58+
margin: 0 auto;
5559

5660
p {
57-
margin: 0
61+
margin: 0 0 0.5em 0;
5862
}
5963
}
6064

@@ -63,15 +67,15 @@
6367
margin: 0;
6468
padding: 0;
6569
list-style-type: none;
70+
text-align: center;
6671
}
6772

6873
li {
6974
display: inline-block;
7075
padding-top: 5px;
7176
padding-bottom: 5px;
72-
font-family: $sans-serif-narrow;
77+
font-family: "Poppins", $sans-serif;
7378
font-size: $type-size-5;
74-
text-transform: uppercase;
7579
}
7680

7781
li + li:before {
@@ -81,67 +85,49 @@
8185

8286
a {
8387
padding-right: 10px;
84-
font-weight: bold;
88+
font-weight: normal;
8589
}
90+
}
8691

87-
.social-icons {
88-
a {
89-
white-space: nowrap;
90-
}
92+
// Footer social icons - consolidated styles with higher specificity
93+
.page__footer .page__footer-follow .social-icons,
94+
.page__footer-follow .social-icons {
95+
a {
96+
white-space: nowrap;
97+
color: rgba($pyos-white, 0.9);
98+
text-decoration: none;
9199

92-
i {
93-
font-size: 0.85em;
94-
margin-right: 0.3em;
100+
&:hover {
101+
color: $pyos-white;
102+
text-decoration: underline;
95103
}
104+
}
96105

97-
// Override all brand colors to be white with grey mixed in
98-
.fas,
99-
.fab,
100-
.far,
101-
.fal,
102-
.fa-behance,
103-
.fa-behance-square,
104-
.fa-bitbucket,
105-
.fa-dribbble,
106-
.fa-dribble-square,
107-
.fa-facebook,
108-
.fa-facebook-square,
109-
.fa-facebook-f,
110-
.fa-flickr,
111-
.fa-foursquare,
112-
.fa-github,
113-
.fa-github-alt,
114-
.fa-github-square,
115-
.fa-gitlab,
116-
.fa-instagram,
117-
.fa-keybase,
118-
.fa-lastfm,
119-
.fa-lastfm-square,
120-
.fa-linkedin,
121-
.fa-linkedin-in,
122-
.fa-mastodon,
123-
.fa-mastodon-square,
124-
.fa-pinterest,
125-
.fa-pinterest-p,
126-
.fa-pinterest-square,
127-
.fa-reddit,
128-
.fa-rss,
129-
.fa-rss-square,
130-
.fa-soundcloud,
131-
.fa-stack-exchange,
132-
.fa-stack-overflow,
133-
.fa-tumblr,
134-
.fa-tumblr-square,
135-
.fa-twitter,
136-
.fa-twitter-square,
137-
.fa-vimeo,
138-
.fa-vimeo-square,
139-
.fa-vimeo-v,
140-
.fa-vine,
141-
.fa-youtube,
142-
.fa-xing,
143-
.fa-xing-square {
144-
color: rgba($pyos-white, 0.85) !important;
145-
}
106+
i,
107+
.fas,
108+
.fab,
109+
.far,
110+
.fal {
111+
font-size: 0.75em;
112+
margin-right: 0.3em;
113+
color: rgba($pyos-white, 0.85);
114+
}
115+
116+
// Override all brand colors to be white - higher specificity without !important
117+
.fa-github,
118+
.fa-github-alt,
119+
.fa-github-square,
120+
.fa-gitlab,
121+
.fa-linkedin,
122+
.fa-linkedin-in,
123+
.fa-mastodon,
124+
.fa-mastodon-square,
125+
.fa-reddit,
126+
.fa-rss,
127+
.fa-rss-square,
128+
.fa-stack-exchange,
129+
.fa-stack-overflow,
130+
.fa-youtube {
131+
color: rgba($pyos-white, 0.85);
146132
}
147133
}

_sass/minimal-mistakes/_pyos-grid.scss

Lines changed: 59 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,13 @@ $colors: (
2424
// Include the mixin
2525
//@include generate-color-styles($colors);
2626

27+
// Shared mixin for auto-responsive grid behavior
28+
@mixin responsive-grid($min-width, $gap: 8px) {
29+
display: grid;
30+
grid-gap: $gap;
31+
grid-template-columns: repeat(auto-fit, minmax($min-width, 1fr));
32+
}
33+
2734
.clearfix::after {
2835
content: "";
2936
display: table;
@@ -53,10 +60,10 @@ $colors: (
5360
&.advisory-council-grid {
5461
grid-template-columns: repeat(4, 1fr);
5562
grid-gap: 8px;
56-
@media screen and (max-width: 1199px) {
63+
@media screen and (max-width: $x-large) {
5764
grid-template-columns: repeat(3, 1fr);
5865
}
59-
@media screen and (max-width: 768px) {
66+
@media screen and (max-width: $medium) {
6067
grid-template-columns: repeat(2, 1fr);
6168
}
6269
}
@@ -93,6 +100,35 @@ $colors: (
93100
}
94101
}
95102

103+
// Home page and volunteer page new contributors section - auto-responsive
104+
.entries-grid {
105+
display: grid;
106+
grid-gap: 8px;
107+
grid-template-columns: 1fr; // Mobile: 1 column
108+
109+
> * {
110+
max-width: 280px;
111+
width: 100%;
112+
}
113+
114+
@media (min-width: $small) {
115+
grid-template-columns: repeat(2, 1fr); // Small: 2 columns
116+
}
117+
118+
@media (min-width: $medium) {
119+
grid-template-columns: repeat(3, 1fr); // Medium: 3 columns
120+
}
121+
122+
@media (min-width: $large) {
123+
grid-template-columns: repeat(4, 1fr); // Large: 4 columns
124+
}
125+
}
126+
127+
// Home page packages section - auto-responsive
128+
.packages-grid {
129+
@include responsive-grid(350px, 10px);
130+
}
131+
96132
.grid-item {
97133
background: #f9f9f9;
98134
border: 1px solid #ddd;
@@ -430,10 +466,24 @@ $colors: (
430466
}
431467

432468
.contrib_org,.ppl_social {
433-
font-size: 1rem;
469+
font-size: 0.875rem;
434470
font-weight:normal;
435471
margin-bottom: 0!important;
436472
}
473+
474+
// Social links in people cards
475+
.ppl_social {
476+
a {
477+
margin-right: 10px;
478+
text-decoration: none !important;
479+
}
480+
481+
// Font Awesome icons inherit font-size from parent
482+
.fa-brands,
483+
.fa-solid {
484+
font-size: inherit;
485+
}
486+
}
437487
.package_description {
438488
font-size: .95rem;
439489
line-height: 1.5rem;
@@ -484,7 +534,7 @@ $colors: (
484534

485535

486536
/* max 480 px */
487-
@media screen and (max-width: 480px) {
537+
@media screen and (max-width: $mobile) {
488538
// large buttons are disproportionately large
489539
// Elements outside of notice blocks such as the blog page
490540
.blog__grid {
@@ -507,6 +557,11 @@ $colors: (
507557
}
508558
}
509559

560+
// Responsive social links in people cards
561+
.ppl_social {
562+
font-size: .9em !important;
563+
}
564+
510565
// the home page has this grid in a notice block
511566
.notice {
512567
.card-body p, .card-body h2 {

0 commit comments

Comments
 (0)