Skip to content

inconsistent parameters? #211

@shizhan1992

Description

@shizhan1992

self.mine.routine(generated, Z, generated, Z_P)

Hi, thank you for this great repository.
I am wondering if line 94 and line 111 are correct? shouldn't it be self.mine.routine(generated, generated, Z, Z_P)? because the routine accepts arguments in the order of "X_real, X_fake, Z_real, Z_fake".

Besides, line 123 "self.mine.visualize(generated, generated, Z, Z_N, targets)" seems correct.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions