self review

Author: Archmonger

src/reactpy/reactjs/module.py

@@ -11,10 +11,10 @@
 from reactpy.reactjs.utils import (
     are_files_identical,
     copy_file,
+    file_lock,
     module_name_suffix,
     resolve_from_module_file,
     resolve_from_module_url,
-    simple_file_lock,
 )
 from reactpy.types import ImportSourceDict, JavaScriptModule, VdomConstructor
 
@@ -56,7 +56,7 @@ def file_to_module(
     source_file = Path(file).resolve()
     target_file = get_module_path(name)
 
-    with simple_file_lock(target_file.with_name(target_file.name + ".lock")):
+    with file_lock(target_file.with_name(f"{target_file.name}.lock")):
         if not source_file.exists():
             msg = f"Source file does not exist: {source_file}"
             raise FileNotFoundError(msg)

src/reactpy/reactjs/utils.py

@@ -204,7 +204,7 @@ def copy_file(target: Path, source: Path, symlink: bool) -> None:
 
 
 @contextmanager
-def simple_file_lock(lock_file: Path, timeout: float = 10.0):
+def file_lock(lock_file: Path, timeout: float = 10.0):
     start_time = time.time()
     while True:
         try:

src/reactpy/testing/display.py

@@ -67,7 +67,6 @@ async def __aenter__(self) -> DisplayFixture:
         return self
 
     async def configure_page(self) -> None:
-        """Hook for configuring the page before use."""
         if getattr(self, "page", None) is None:
             self.page = await self.browser.new_page()
             self.page.set_default_timeout(REACTPY_TESTS_DEFAULT_TIMEOUT.current * 1000)

tests/test_reactjs/test_utils.py

@@ -6,12 +6,12 @@
 
 from reactpy.reactjs.utils import (
     copy_file,
+    file_lock,
     module_name_suffix,
     normalize_url_path,
     resolve_from_module_file,
     resolve_from_module_source,
     resolve_from_module_url,
-    simple_file_lock,
 )
 from reactpy.testing import assert_reactpy_did_log
 
@@ -196,5 +196,5 @@ def test_simple_file_lock_timeout(tmp_path):
     with patch("os.open", side_effect=OSError):
         with patch("time.sleep"):  # Speed up test
             with pytest.raises(TimeoutError, match="Could not acquire lock"):
-                with simple_file_lock(lock_file, timeout=0.1):
+                with file_lock(lock_file, timeout=0.1):
                     pass