From 2a467d2d9979b68caebf878429fdb9bcc555d924 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Christian=20L=C3=BCck?= Date: Sat, 29 Apr 2017 01:13:17 +0200 Subject: [PATCH] Mark internal API as private to discourage inheritance --- src/DuplexResourceStream.php | 15 +++++++++------ src/ReadableResourceStream.php | 13 +++++++------ 2 files changed, 16 insertions(+), 12 deletions(-) diff --git a/src/DuplexResourceStream.php b/src/DuplexResourceStream.php index 8a9f070..113c9aa 100644 --- a/src/DuplexResourceStream.php +++ b/src/DuplexResourceStream.php @@ -8,6 +8,9 @@ class DuplexResourceStream extends EventEmitter implements DuplexStreamInterface { + private $stream; + private $loop; + /** * Controls the maximum buffer size in bytes to read at once from the stream. * @@ -25,13 +28,11 @@ class DuplexResourceStream extends EventEmitter implements DuplexStreamInterface * @var int */ private $bufferSize; + private $buffer; - private $stream; - protected $readable = true; - protected $writable = true; - protected $closing = false; - protected $loop; - protected $buffer; + private $readable = true; + private $writable = true; + private $closing = false; public function __construct($stream, LoopInterface $loop, $readChunkSize = null, WritableStreamInterface $buffer = null) { @@ -157,6 +158,7 @@ public function pipe(WritableStreamInterface $dest, array $options = array()) return Util::pipe($this, $dest, $options); } + /** @internal */ public function handleData($stream) { $error = null; @@ -189,6 +191,7 @@ public function handleData($stream) } } + /** @internal */ public function handleClose() { if (is_resource($this->stream)) { diff --git a/src/ReadableResourceStream.php b/src/ReadableResourceStream.php index 88d42ec..3edf80e 100644 --- a/src/ReadableResourceStream.php +++ b/src/ReadableResourceStream.php @@ -8,6 +8,13 @@ class ReadableResourceStream extends EventEmitter implements ReadableStreamInterface { + /** + * @var resource + */ + private $stream; + + private $loop; + /** * Controls the maximum buffer size in bytes to read at once from the stream. * @@ -28,13 +35,7 @@ class ReadableResourceStream extends EventEmitter implements ReadableStreamInter */ private $bufferSize; - /** - * @var resource - */ - private $stream; - private $closed = false; - private $loop; public function __construct($stream, LoopInterface $loop, $readChunkSize = null) {