-
Notifications
You must be signed in to change notification settings - Fork 198
Open
Labels
enhancementThis tackles a new feature of the code (and not a bug)This tackles a new feature of the code (and not a bug)
Description
As I observed, there isn't any APIs to pause/resume/start diagnostic updaters. Especially when invoking diagnostic_updaters in LifecycleNodes, diagnostic updaters begins publishing topic to /diagnostics just after LifecycleNodes constructing. As description in Managed Nodes, publishers in Lifecyclenodes should be configured and activated before publishing topics.
In my opinion, there are two ways:
- We need to add some APIs to pause/resume/start updaters for special usage. Then we will face with choices: Will updater run timer by default? or updater only run timer after called "start" function?
- We add a new header file, eg. diagnostic_updater_lifecycle.hpp. And create a class derived from
DiagnosticTaskVectorthat classUpdaterderived. Then implement all LifecycleNodes' APIs in it.
vinnnyr and LoicFerrotZhenshengLee and KevinSchwarzer
Metadata
Metadata
Assignees
Labels
enhancementThis tackles a new feature of the code (and not a bug)This tackles a new feature of the code (and not a bug)