Conditional Fields issue ?

[srabouin]

https://github.com/royale-proxy/cr-messages-python/blob/master/decoder.py#L90
I think this should have a read(1) to get rid of the 0 byte, otherwise it gets moved to the next field since it only peeks. I have used components instead with extensions id 0/1 to get rid of that byte. I am not 100% sure, hopefully someone can verify this theory. Is this used somewhere else correctly?

[123456abcdef]

I think this was working back then, when clugh released it. I think this part handels a special case if you have two optional fields back to back. In this case you won't have one boolean for each field, but both boolean merged together. Like 0b01 if first field exists, second not, or 0b11 if both fields exists (Example from CoC ). I'm not to sure anymore how exactly this was working and if CR has a similiar thing in their protocol.