From 96300afabead4cda3c600243eba1b5e2d22e75dd Mon Sep 17 00:00:00 2001 From: Pedro Kostelec Date: Sun, 20 Sep 2015 15:08:41 +0200 Subject: [PATCH 1/2] Use instance initializer to get instace of the router --- ember-google-analytics.js | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/ember-google-analytics.js b/ember-google-analytics.js index 0be0b7a..a38ab91 100644 --- a/ember-google-analytics.js +++ b/ember-google-analytics.js @@ -39,8 +39,14 @@ Ember.GoogleAnalyticsTrackingMixin = Ember.Mixin.create({ Ember.Application.initializer({ name: "googleAnalytics", - initialize: function(container, application) { - var router = container.lookup('router:main'); + initialize: function(registry, application) { + } +}); +Ember.Application.instanceInitializer({ + name: "googleAnalytics", + + initialize: function(instance) { + var router = instance.container.lookup('router:main'); router.on('didTransition', function() { this.trackPageView(router.rootURL.slice(0, -1) + this.get('url')); }); From c22e49d383d3a0ba0bc900f058a6279d1791315b Mon Sep 17 00:00:00 2001 From: Pedro Kostelec Date: Sat, 24 Oct 2015 14:04:41 +0200 Subject: [PATCH 2/2] Resolved deprecation on initializer arity --- ember-google-analytics.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/ember-google-analytics.js b/ember-google-analytics.js index a38ab91..a8afdb2 100644 --- a/ember-google-analytics.js +++ b/ember-google-analytics.js @@ -39,14 +39,14 @@ Ember.GoogleAnalyticsTrackingMixin = Ember.Mixin.create({ Ember.Application.initializer({ name: "googleAnalytics", - initialize: function(registry, application) { + initialize: function(application) { } }); Ember.Application.instanceInitializer({ name: "googleAnalytics", - initialize: function(instance) { - var router = instance.container.lookup('router:main'); + initialize: function(appInstance) { + var router = appInstance.lookup('router:main'); router.on('didTransition', function() { this.trackPageView(router.rootURL.slice(0, -1) + this.get('url')); });