-
Notifications
You must be signed in to change notification settings - Fork 4
Open
Labels
enhancementNew feature or requestNew feature or request
Description
Things I'm considering fixing:
PasswordClient(and its friendsplainanddigest) returnResult<_, String>. They should use a realstd::error::Errorimpl instead.- Each digest type should probably be an individual optional dependency, rather than having
digestpull in bothmd5andsha2crates. In particular, I think it's rare for servers to use the SHA digest types, and folks might not want to have that dependency. - Rename
http_auth::digest::Algorithm::Sha512Trunc256toSha512_256to match the change with sha2 version 0.10.0. ParamValueshould probably be calledParamValueReffor consistency withChallengeRef.http_auth::basic::BasicClientandhttp_auth::digest::DigestClientmaybe should behttp_auth::basic::Clientandhttp_auth::digest::Clientrespectively to eliminate the "stuttering" in the type names.http_auth::PasswordClientBuildercould just take awithmethod based on a trait that adds stuff to the client, avoiding the need for somewhat arbitrarily chosen distinct method names for thestrvsChallengeRefvshttp::HeaderValuevshttp::GetAllcases
Other suggestions welcome.
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or request