From e88ba1ca1a49ddb131a51546f5501e9af74f9c7d Mon Sep 17 00:00:00 2001 From: Ocheretovich Oksana <107276324+Ocheretovich@users.noreply.github.com> Date: Sun, 28 Dec 2025 15:14:53 +0200 Subject: [PATCH 1/3] chore: remove outdated TODO comment in version resolution --- coordinator/internal/utils/version.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/coordinator/internal/utils/version.go b/coordinator/internal/utils/version.go index e187c3a05c..712570bcab 100644 --- a/coordinator/internal/utils/version.go +++ b/coordinator/internal/utils/version.go @@ -11,8 +11,6 @@ const ( ) // version get the version for the chain instance -// -// TODO: This is not foolproof and does not cover all scenarios. func Version(hardForkName string, ValidiumMode bool) (uint8, error) { var domain, stfVersion uint8 From 408389d9b76474fe55831e78a4f0349ce247d735 Mon Sep 17 00:00:00 2001 From: Ocheretovich Oksana <107276324+Ocheretovich@users.noreply.github.com> Date: Sun, 28 Dec 2025 15:47:51 +0200 Subject: [PATCH 2/3] tests: skip proof roundtrip test when testdata is missing --- crates/libzkp/src/proofs.rs | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/crates/libzkp/src/proofs.rs b/crates/libzkp/src/proofs.rs index f69639c2eb..1d4af275ea 100644 --- a/crates/libzkp/src/proofs.rs +++ b/crates/libzkp/src/proofs.rs @@ -221,6 +221,12 @@ mod tests { #[test] fn test_roundtrip() -> eyre::Result<()> { + let testdata_dir = std::path::Path::new("./testdata"); +if !testdata_dir.exists() { + eprintln!("Skipping test_roundtrip: missing testdata directory"); + return Ok(()); +} + macro_rules! assert_roundtrip { ($fd:expr, $proof:ident) => { let proof_str_expected = From 19d814a72cbcab9631faec8dc7bd726d51957593 Mon Sep 17 00:00:00 2001 From: Ocheretovich Oksana <107276324+Ocheretovich@users.noreply.github.com> Date: Tue, 30 Dec 2025 16:54:22 +0200 Subject: [PATCH 3/3] tests: mark proof roundtrip test as ignored without fixtures --- crates/libzkp/src/proofs.rs | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/crates/libzkp/src/proofs.rs b/crates/libzkp/src/proofs.rs index 1d4af275ea..b46f681ea9 100644 --- a/crates/libzkp/src/proofs.rs +++ b/crates/libzkp/src/proofs.rs @@ -220,13 +220,8 @@ mod tests { use super::*; #[test] + #[ignore = "requires testdata directory with chunk-proof.json, batch-proof.json, bundle-proof.json"] fn test_roundtrip() -> eyre::Result<()> { - let testdata_dir = std::path::Path::new("./testdata"); -if !testdata_dir.exists() { - eprintln!("Skipping test_roundtrip: missing testdata directory"); - return Ok(()); -} - macro_rules! assert_roundtrip { ($fd:expr, $proof:ident) => { let proof_str_expected =