Sunstaff issue

[tallustelija]

uhexen2/gamecode/hc/h2/sunstaff.hc

Lines 225 to 233 in 89191f6

	void sunstaff_deselect (void)
	{
	//go to ready loop, not relaxed?
	self.wfs = advanceweaponframe($select14,$select1);
	self.th_weapon=sunstaff_deselect;
	if(self.wfs==WF_CYCLE_WRAPPED)
	W_SetCurrentAmmo();
	}

There's a visual bug with the sunstaff that dates back to the original HexenC releases. If sunstaff is in firing animation, fire key is released and weapon is changed quickly, the EF_BRIGHTLIGHT effect will stay on indefinitely.

Adding

self.effects(-)EF_BRIGHTLIGHT;

on line 231 of sunstaff.hc seems to fix this. I haven't noticed side effects. See attached demos.
sunstaff_bug.zip

[sezero]

I can see it in the demos, but I can't reproduce the thing: How do you so quickly switch to a different weapon to trigger this?

[sezero]

Never mind, I did manage to reproduce using mouse scroll to switch weapons.

[sezero]

Don't know whether I want to fix it, though. I'd like to make a release soon (I hope.. after 6 years...)

[tallustelija]

Alright, yeah it isn't a high priority bug.

Works as a free torchlight effect which is nice :)

Good luck with the next version release!

[sezero]

Alright, yeah it isn't a high priority bug.

Indeed

Works as a free torchlight effect which is nice :)

😄

Good luck with the next version release!

Thanks