Incorrect damage display in the inventory

[dekrus]

sfall (v4.4.0+) (Bug not present in v4.3.8)
Steps to reproduce:
1. Start a new game.
2. Open the inventory.
3. Place spear into the left hand slot.
4. Move the spear to the right hand slot, then back to the left, then to the right again.
5. Exit the inventory.
6. Open the inventory again.
7. Move the spear from the right slot to the left slot.
8. Remove the spear from the slot (make the slot empty).

Punch damage is incorrectly duplicated for both slots.

[NovaRain]

Weird, I couldn't reproduce it on my system (UPU w/o any 3rd-party mods). This is how the inventory shows after following your steps:

Also in your first pic, Narg is still holding a spear while it's already unequipped. Something went obviously wrong in your game, maybe try to pinpoint which component of your mod is triggering this issue?

[dekrus]

This might sound silly, but do the following:
1.Uncomment the line ElevatorsFile=sfall\Elevators.ini
2.Do NOT create the sfall\Elevators.ini file itself.
3.Try reproducing the bug again with these steps.

I tried it on a clean GOG version of Fallout 2 with sfall 4.4.8.
But with ddraw.ini from diff install

[NovaRain]

UPU doesn't have any elevators.ini. It's a RP addition.

EDIT: and I just installed a clean GOG version, copied sfall 4.4.8 files to it, set a windowed game, and still couldn't reproduce it.

[dekrus]

I checked on the RPU with no additional mods.
The same bug occurs, until I comment out the line for ElevatorsFile=sfall\Elevators.ini (note: the Elevators.ini file does exist).

The presence or absence of the actual Elevators.ini file does not matter. The game version and installed mods also do not affect the result in my case. The only determining factor is the sfall version and ElevatorsFile=sfall\Elevators.ini | ;ElevatorsFile=sfall\Elevators.ini.

What else should I check?

[NovaRain]

OK, I do reproduce it now with ElevatorsFile uncommented but no elevators.ini (or more precisely, sfall doesn't actually load the ini). And it seems only reproducible starting from 4.4.0.1, With older "4.4" version I can't seem to reproduce it, also 3.8.4x don't have this issue.

EDIT: this one is kinda hit-and-miss, as I got a few cases that happened even with 4.3.8, or didn't trigger with 4.4.x. Does it have to be one slot empty (unarmed) with one weapon switching back and forth?

EDIT 2: Can you try this test build, see if the issue still happens with ElevatorsFile or even other ini file options?
sfall-invdmg-test.zip

[dekrus]

I tested this test build, and so far everything is working. This bug does not occur under any condition of 'ElevatorsFile=elevators.ini' (neither with the file present nor missing). I also tested by enabling (uncommenting) all possible options in ddraw.ini

Can you please explain how 'ElevatorsFile=' could lead to this problem?

[NovaRain]

In my tests, missing ini is what triggers the issue. If I drop RP's elevators.ini to the specified path in a basic FO2 installation (be it the game root or "sfall" subfolder), things would work just fine on my two systems.

Here's another test build: sfall-invdmg-test2.zip

As for the explanation, I only have a vague guess that it might come from Visual Studio codegen as I didn't notice anything wrong in code of all related modules, and 3.8.4x shares pretty much the same code but it doesn't have this issue (at least on my side, if you have some free time maybe you can verify that on your system).

[dekrus]

I've never been able to reproduce this bug on the both test builds and on v3.8.48

However, in version 4.4.8, the bug occurs for me even when the elevators.ini file is present.
Important details for reproducing the bug in 4.4.8:
The bug occurs only if ElevatorsFile is uncommented and its value is non-empty (can be any value, even 1 character or digit). A blank value (ElevatorsFile=) prevents the bug.

It is not necessary for hand slots to be empty or for the moved items to be weapons.
The key is to follow a specific sequence of actions after launching the game (fallout2.exe or fallout2HR.exe):
    Place an item into the left slot (if it is empty).
    Move an item from the left slot to the right slot.
    Move it back to the left slot.
    Move it back to the right slot.
    Exit the inventory.
    Re-enter the inventory.
    Completely empty the right slot (so that unarmed damage is displayed there).

If this sequence is broken at any step, the bug will not occur again until i fully restart the game (via .exe). Starting a new game or loading a saved file during the same game session does not reset the conditions necessary to trigger the bug, once the sequence has been broken.

[NovaRain]

I couldn't figure out the exact reason, but the cause related to ElevatorsFile is from here:

manager.add<EngineTweaks>();
manager.add<Books>();
manager.add<Criticals>();
manager.add<Elevators>();
manager.add<Unarmed>();

If I move Unarmed module initialization right after EngineTweaks, the same problem will happen with TweaksFile instead. So for now my solution is to simply move it away from the other four modules.