diff --git a/.github/workflows/deploy.yml b/.github/workflows/deploy.yml index a56eb424..d7cc641e 100644 --- a/.github/workflows/deploy.yml +++ b/.github/workflows/deploy.yml @@ -59,5 +59,6 @@ jobs: # Downloading artifacts to new instances is already convenient via aws credentials and cli run: (cd deploy && npm run upload ${{ inputs.environment }}) + # FIXME: Deploy will fail unless removed elastic IP addresses restored/replaced - name: Deploy run: (cd deploy && npm start ${{ inputs.environment }}) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 1de84742..0cfaaa78 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -13,11 +13,11 @@ jobs: uses: ./.github/workflows/branch.yml secrets: inherit - main-deploy: - needs: - - main-branch - uses: ./.github/workflows/deploy.yml - with: - environment: production - url: https://www.trshcmpctr.com - secrets: inherit + # main-deploy: + # needs: + # - main-branch + # uses: ./.github/workflows/deploy.yml + # with: + # environment: production + # url: https://www.trshcmpctr.com + # secrets: inherit diff --git a/.github/workflows/staging.yml b/.github/workflows/staging.yml index 6a2d6595..781c7614 100644 --- a/.github/workflows/staging.yml +++ b/.github/workflows/staging.yml @@ -13,11 +13,11 @@ jobs: uses: ./.github/workflows/branch.yml secrets: inherit - stage-deploy: - needs: - - stage-branch - uses: ./.github/workflows/deploy.yml - with: - environment: staging - url: https://www-stage.trshcmpctr.com - secrets: inherit + # stage-deploy: + # needs: + # - stage-branch + # uses: ./.github/workflows/deploy.yml + # with: + # environment: staging + # url: https://www-stage.trshcmpctr.com + # secrets: inherit diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index c71472a7..c4ccea03 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -6,6 +6,8 @@ Notes specifically for repository maintainers * can't upgrade to/past [@microsoft/rush@5.132.0](https://github.com/microsoft/rushstack/blob/a9b6c472c31676e5ae4fcd594c311a6b6029e82e/apps/rush/CHANGELOG.md#51320) since changes to `decoupledLocalDependencies` +* (@trshcmpctr/client) start command: +[webpack-dev-middleware] HookWebpackError: HMR is not implemented for module chunk format yet ## TODOs diff --git a/deploy/lib/index.js b/deploy/lib/index.js index 161b5d5b..bb0c12dd 100644 --- a/deploy/lib/index.js +++ b/deploy/lib/index.js @@ -22,11 +22,13 @@ if (!environmentArgument) { */ const getElasticIpAllocationId = environment => { if (environment === 'staging') { + // FIXME: this elastic IP is removed // www-stage.trshcmcptr.com return 'eipalloc-0b8f0bb1660204bec'; } if (environment === 'production') { + // FIXME: this elastic IP is removed // www.trshcmpctr.com return 'eipalloc-022c7934990a883c8'; } @@ -131,6 +133,7 @@ if (!isReady) { throw new Error(`next instance not running after polling ${attempts} times`); } +// FIXME: Deploy will fail unless removed elastic IP addresses restored/replaced // try to assign environment elastic ip address to new instance try { await ec2AssociateIp(nextInstanceId, getElasticIpAllocationId(environmentArgument));