Replace Psalm with PHPStan

Author: tvdijen

.gitattributes

@@ -5,8 +5,10 @@ codecov.yml export-ignore
 .editorconfig export-ignore
 .gitattributes export-ignore
 .gitignore export-ignore
-psalm.xml export-ignore
-psalm-dev.xml export-ignore
+phpstan.neon export-ignore
+phpstan-dev.neon export-ignore
+phpstan-baseline.neon export-ignore
+phpstan-baseline-dev.neon export-ignore
 phpcs.xml export-ignore
 phpunit.xml export-ignore
 .php_cs.dist export-ignore

phpstan-dev.neon

@@ -0,0 +1,4 @@
+parameters:
+  level: 9
+  paths:
+    - tests

phpstan.neon

@@ -0,0 +1,4 @@
+parameters:
+  level: 8
+  paths:
+    - src

psalm-dev.xml

@@ -32,7 +32,7 @@ class Radius extends UserPassBase
     public const RADIUS_NAS_IDENTIFIER = 32;
 
     /**
-     * @var array The list of radius servers to use.
+     * @var array<mixed> The list of radius servers to use.
      */
     private array $servers;
 
@@ -91,8 +91,8 @@ class Radius extends UserPassBase
     /**
      * Constructor for this authentication source.
      *
-     * @param array $info  Information about this authentication source.
-     * @param array $config  Configuration.
+     * @param array<mixed> $info  Information about this authentication source.
+     * @param array<mixed> $config  Configuration.
      */
     public function __construct(array $info, array $config)
     {
@@ -135,7 +135,7 @@ public function __construct(array $info, array $config)
      *
      * @param string $username  The username the user wrote.
      * @param string $password  The password the user wrote.
-     * @return array[] Associative array with the user's attributes.
+     * @return array<mixed> Associative array with the user's attributes.
      */
     protected function login(
         string $username,
@@ -223,7 +223,7 @@ protected function login(
 
     /**
      * @param \Dapphp\Radius\Radius $radius
-     * @return array
+     * @return array<mixed>
      */
     private function getAttributes(RadiusClient $radius): array
     {
@@ -244,7 +244,7 @@ private function getAttributes(RadiusClient $radius): array
         $resv = $resa['data'];
         if ($resv === false) {
             throw new Exception(sprintf(
-                'Error getting vendor specific attribute',
+                'Error getting vendor specific attribute: %s (%d)',
                 $radius->getErrorMessage(),
                 $radius->getErrorCode(),
             ));
@@ -259,15 +259,9 @@ private function getAttributes(RadiusClient $radius): array
         }
 
         $attrib_name = strtok($datav, '=');
-        /** @psalm-suppress TooFewArguments */
         $attrib_value = strtok('=');
 
-        // if the attribute name is already in result set, add another value
-        if (array_key_exists($attrib_name, $attributes)) {
-            $attributes[$attrib_name][] = $attrib_value;
-        } else {
-            $attributes[$attrib_name] = [$attrib_value];
-        }
+        $attributes[$attrib_name] = [$attrib_value];
 
         return $attributes;
     }