Errors during sending are not printed out

[arxeiss]

Recently we did mistake, and stored incorrect Slack Token into Github Secret, which is used in slack-github-action. But we got no error back, which left us clueless what is wrong.

I'm not talking about #473, we don't want to set errors: true. Because that would block our pipeline. It is fine that action succeed.
But it would be nice to print out that error, so we have at least some feedback.

Here is our action step:

    - name: Send Slack Notification
        id: send-notification
        uses: slackapi/slack-github-action@91efab103c0de0a537f72a35f6b8cda0ee76bf0a # v2.1.1 - https://github.com/slackapi/slack-github-action/releases
        with:
          token: ${{ secrets.SLACK_BOT_TOKEN }}
          method: chat.postMessage
          payload: >-
            {
              "channel": "${{ secrets.SLACK_CHANNEL_FOR_DEPLOYMENT }}",
              "text": "*Starting new release ${{ github.event.release.tag_name }}.*"
            }

And this is what we see. No output, but no message in Slack either.

[hello-ashleyintech]

Hi, @arxeiss! Thank you for submitting this!

Could you try something like the following and generate a webhook URL to post the message to a channel:

    - name: Attempt to send Slack notification
      id: slack_notification
      uses: slackapi/slack-github-action@91efab103c0de0a537f72a35f6b8cda0ee76bf0a
      with:
        webhook: ${{ secrets.SLACK_WEBHOOK_URL }}
        payload: |
          {
            "text": "Test message"
          }

    - name: Check Slack notification status
      if: steps.slack_notification.outputs.ok == 'false'
      run: |
        echo "Slack notification failed with error: ${{ steps.slack_notification.outputs.error }}"

Let me know if that works!

[arxeiss]

I tried with invalid token, because that is what we use. So with this workflow

      - name: Slack Notification
        id: slack_notification
        uses: slackapi/slack-github-action@91efab103c0de0a537f72a35f6b8cda0ee76bf0a # v2.1.1 - https://github.com/slackapi/slack-github-action/releases
        with:
          token: https://hooks.slack.com/services/T090889/S343245/G62456245
          method: chat.postMessage
          payload: >-
            {
              "channel": "${{ secrets.SLACK_CHANNEL_FOR_DEPLOYMENT }}",
              "text": ":alert: Changes detected"
            }

      - name: Check Slack notification status
        if: steps.slack_notification.outputs.ok == 'false'
        run: |
          echo "Slack notification failed with error: ${{ steps.slack_notification.outputs.response }}"

I actually got response Slack notification failed with error: {ok:false,error:invalid_auth,response_metadata:{}}.
However, that seems pretty strange to add another step only to print out error.

[zimeg]

@arxeiss I agree that printing these logs as part of the step would make debugging more simple! Let's change this to be an enhancement for an upcoming release 🚀 ✨

I'm also interested in improving options around verbose logging, but we can perhaps revisit that alongside those change?

[arxeiss]

@zimeg sure, I checked code quickly and it seems logger is initialized, but never actually used. So improving logging in general might be a good too.