"Disable Screensaver" does not work since update v24.5.0-1

[initd0]

Describe the bug
Since update v24.5.0-1 in May 2024, the option for "Disable Screensaver" no longer works.
I was on version 23.12.0-1 on Jammy, and i never had an issue until this update. I also have no issue like this with VLC.

I tried to downgrade with apt-get install smplayer=23.12.0 and it says it cant find the version.
I then removed the ppa from rvm completely and im now using the default ubuntu version smplayer: Installed: 21.10.0~ds0-1 without any issues.

Any idea why this is happening, what has changed and why no-one else has picked this issue up since May? I havent been able to find any issues related to this.

Expected behavior
I want the Disable screensaver to work like it used to, so that it doesnt auto-lock the screen when watching a video.

Your Enviroment

• SMPlayer version: 24.5.0-1
• OS: Ubuntu 22.04
• Multimedia engine you're using with SMPlayer (preferences -> general):
  [x] MPlayer
  [ ] MPV

[smplayer-dev]

Could you test if the problem is still present in the development version?
https://github.com/smplayer-dev/smplayer/releases/tag/v24.5.0.10283

[hnsteyding]

SMplayer Version v24.5.0.10283 works for me.

But latest version from git repo not:

smplayer.log
mplayer.log

Your Enviroment:

SMPlayer Version 24.5.0 (Revision 10309) (32-bit)
OS: Windows 7 and Windows 10
Multimedia engine you're using with SMPlayer (preferences -> general):
[x] MPlayer
[ ] MPV

[initd0]

Could you test if the problem is still present in the development version? https://github.com/smplayer-dev/smplayer/releases/tag/v24.5.0.10283

I tried again SMPlayer-24.5.0-x86_64.AppImage & also SMPlayer-24.5.0.10283-x86_64.AppImage as you requested.

As predicted, the "Disable screensaver" setting is not honored in SMPlayer-24.5.0-x86_64.AppImage.

But it is working in the dev version SMPlayer-24.5.0.10283-x86_64.AppImage, thank you. When is the next release coming out?

[hnsteyding]

I found out that the problem exists since the following commit (changes to USE_POWERSAVING):
https://github.com/smplayer-dev/smplayer/tree/4d2edc7f494e01bd34bbae14cc4db1aea6d39c22

[Fat-Zer]

A can confirm, according to journal --no-stop-screensaver is passed to the mpv regardless of the smplayer's option. Also I can confirm that the problem persists in master.

[Fat-Zer]

I've investigated a bit and it looks like in my case the problem is that my DE doesn't provide org.freedesktop.ScreenSaver DBus service, so the smplayer's PowerSaving stuff doesn't work.

It would be nice to add a runtime check if PowerSaving is operational and if it isn't, let mpv/mplayer manage it, rather use a compilation-time-only check.

Gentoo Linux / X11 / mpv

[smplayer-dev]

I think this should be fixed in version 10337. Now you can enable the use of the stop-screesaver option in preferences -> advanced.

https://github.com/smplayer-dev/smplayer/releases/tag/v24.5.0.10337

[Fat-Zer]

I think this should be fixed in version 10337. Now you can enable the use of the stop-screesaver option in preferences -> advanced.

https://github.com/smplayer-dev/smplayer/releases/tag/v24.5.0.10337

It would be nice to have automatic fallback or at least a warning if the smplayer's screensaver controller is non-functional. Besides that this option probably should be available generally for unix platforms, not just linux; and with mpv the option might be usable on non-unix as well.

I may update my PR if you wish.

PS: as for now it still will prevent using mplayer on windows as it can't handle -stop-xscreensaver, see @hnsteyding's reports in #1085

[hnsteyding]

@smplayer-dev:
Releases 24.5.0.10337 doesn't work either - same error:

Unknown option on the command line: -nostop-xscreensaver

[hnsteyding]

Seems to be fixed now in cb6084f

[Fat-Zer]

Now it doesn't pass --no-stop-screensaver to mpv (on win), so mpv will always disable screensaver by default regardless off smplayer's configuration.

Also as for now use_stopscreensaver doesn't stop smplayer from trying to control the screensaver.

And what about automatic apply of it? Having a checkbox is nice, but when the setting is buried in the advanced section it's hard to determine why it doesn't work in the first place.