From d7476641be148e6c98c55c6710de462f7ab929c8 Mon Sep 17 00:00:00 2001 From: Bilal Al-Shahwany Date: Wed, 8 Oct 2025 09:24:24 -0700 Subject: [PATCH 1/4] updated version and changes --- CHANGES.txt | 3 +++ lib/splitclient-rb/version.rb | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/CHANGES.txt b/CHANGES.txt index 2546ab36..f899ea72 100644 --- a/CHANGES.txt +++ b/CHANGES.txt @@ -1,5 +1,8 @@ CHANGES +8.9.0 (Oct 8, 2025) +- Added new configuration for Fallback Treatments, which allows setting a treatment value and optional config to be returned in place of "control", either globally or by flag. Read more in our docs. + 8.8.0 (Sep 26, 2025) - Added a maximum size payload when posting unique keys telemetry in batches diff --git a/lib/splitclient-rb/version.rb b/lib/splitclient-rb/version.rb index 0994b090..1afbdd0a 100644 --- a/lib/splitclient-rb/version.rb +++ b/lib/splitclient-rb/version.rb @@ -1,3 +1,3 @@ module SplitIoClient - VERSION = '8.9.0-rc1' + VERSION = '8.9.0' end From 5652487563280c24d15868519229170c08e25412 Mon Sep 17 00:00:00 2001 From: Bilal Al-Shahwany Date: Wed, 8 Oct 2025 09:36:40 -0700 Subject: [PATCH 2/4] polish --- lib/splitclient-rb/validators.rb | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/lib/splitclient-rb/validators.rb b/lib/splitclient-rb/validators.rb index 20554848..a95a8627 100644 --- a/lib/splitclient-rb/validators.rb +++ b/lib/splitclient-rb/validators.rb @@ -57,8 +57,12 @@ def valid_flag_sets(method, flag_sets) end without_nil = Array.new flag_sets.each { |flag_set| - without_nil.push(flag_set) if !flag_set.nil? - log_nil("flag set", method) if flag_set.nil? + if !flag_set.nil? + without_nil.push(flag_set) + next + end + + log_nil("flag set", method) } if without_nil.length() == 0 log_invalid_flag_set_type(method) From c5c0f3ecc5174c356570aba15716977ea06afd2e Mon Sep 17 00:00:00 2001 From: Bilal Al-Shahwany Date: Wed, 8 Oct 2025 10:45:59 -0700 Subject: [PATCH 3/4] fix test --- spec/integrations/push_client_spec.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/spec/integrations/push_client_spec.rb b/spec/integrations/push_client_spec.rb index f62d6d60..ca206024 100644 --- a/spec/integrations/push_client_spec.rb +++ b/spec/integrations/push_client_spec.rb @@ -170,7 +170,7 @@ end treatment = 'control' - for i in 1..5 do + for i in 1..10 do sleep(1) treatment = client.get_treatment('admin', 'bilal_split') break if treatment != 'control' From 2737680f84240cc92fe701b3bdc56b2dcca5b85f Mon Sep 17 00:00:00 2001 From: Bilal Al-Shahwany Date: Wed, 8 Oct 2025 12:28:26 -0700 Subject: [PATCH 4/4] polish tests --- spec/integrations/push_client_spec.rb | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/spec/integrations/push_client_spec.rb b/spec/integrations/push_client_spec.rb index ca206024..689793a5 100644 --- a/spec/integrations/push_client_spec.rb +++ b/spec/integrations/push_client_spec.rb @@ -140,6 +140,7 @@ expect(a_request(:get, 'https://sdk.split.io/api/splitChanges?s=1.3&since=-1&rbSince=-1')).to have_been_made.times(1) expect(a_request(:get, 'https://sdk.split.io/api/splitChanges?s=1.3&since=1585948850109&rbSince=-1')).to have_been_made.times(1) expect(a_request(:get, 'https://sdk.split.io/api/splitChanges?s=1.3&since=1585948850110&rbSince=-1')).to have_been_made.times(0) + client.destroy end end @@ -177,6 +178,7 @@ end expect(treatment).to eq('off') + client.destroy end end @@ -206,6 +208,7 @@ sleep(2) expect(client.get_treatment('admin', 'bilal_split')).to eq('control') expect(client.get_treatment('admin', 'push_test')).to eq('after_fetch') + client.destroy end end @@ -235,6 +238,7 @@ sleep(2) expect(client.get_treatment('admin', 'bilal_split')).to eq('control') expect(client.get_treatment('admin', 'push_test')).to eq('after_fetch') + client.destroy end end @@ -264,6 +268,7 @@ sleep(2) expect(client.get_treatment('admin', 'bilal_split')).to eq('control') expect(client.get_treatment('admin', 'push_test')).to eq('after_fetch') + client.destroy end end end