Skip to content

Simplify LettuceConnectionUnitTests #3276

@onobc

Description

@onobc

Currently the LettuceConnectionUnitTests are testing all variations of the conversion from options to Lettuce params.

However, most of these conversions are handles in the Lettuce StreamConverters class. Ideally these variants would be unit tested well in a StreamConvertersUnitTests. This is the pattern that Jedis uses.

This would allow the LettuceConnectionUnitTests to be simplified and just verify that the options were passed in during the API call rather than test all conversion variants.

  • Introduce a Lettuce StreamConvertersUnitTests (can use Jedis counterpart for inspiration)
  • Simplify the LettuceConnectionUnitTests in favor of the above
  • Be sure to include all APIs that handle their options -> params conversions via StreamConverters (e.g. xadd, xtrim, etc...)

Metadata

Metadata

Assignees

No one assigned

    Type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions