Skip to content

Commit 14b10dd

Browse files
committed
fix layout jumping
1 parent 6db4c38 commit 14b10dd

File tree

2 files changed

+25
-16
lines changed

2 files changed

+25
-16
lines changed

app.mjs

Lines changed: 12 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -58,36 +58,38 @@ created_at DATETIME NOT NULL
5858

5959
async function runDiff() {
6060
// Run up diff (current -> desired)
61-
outputUp.style.display = "none";
62-
errorUp.style.display = "none";
61+
errorUp.classList.add("hidden");
6362
try {
6463
const result = await sqldef(
6564
dbType.value,
6665
inputB.value,
6766
inputA.value,
6867
enableDrop.checked
6968
);
70-
outputUp.innerHTML = result;
71-
outputUp.style.display = "block";
69+
outputUp.textContent = result;
70+
outputUp.className = "language-sql";
71+
Prism.highlightElement(outputUp);
7272
} catch (e) {
73-
errorUp.style.display = "block";
73+
outputUp.innerHTML = " ";
74+
errorUp.classList.remove("hidden");
7475
errorUp.innerHTML = e.message;
7576
}
7677

7778
// Run down diff (desired -> current)
78-
outputDown.style.display = "none";
79-
errorDown.style.display = "none";
79+
errorDown.classList.add("hidden");
8080
try {
8181
const result = await sqldef(
8282
dbType.value,
8383
inputA.value,
8484
inputB.value,
8585
enableDrop.checked
8686
);
87-
outputDown.innerHTML = result;
88-
outputDown.style.display = "block";
87+
outputDown.textContent = result;
88+
outputDown.className = "language-sql";
89+
Prism.highlightElement(outputDown);
8990
} catch (e) {
90-
errorDown.style.display = "block";
91+
outputDown.innerHTML = " ";
92+
errorDown.classList.remove("hidden");
9193
errorDown.innerHTML = e.message;
9294
}
9395
}

index.html

Lines changed: 13 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919
<link rel="apple-touch-icon" sizes="512x512" href="sqldef512.png">
2020

2121
<link href="https://fonts.googleapis.com/css?family=Raleway&display=swap" rel="stylesheet">
22+
<link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/prism/1.30.0/themes/prism-tomorrow.min.css">
2223

2324
<style>
2425
body {
@@ -44,9 +45,13 @@
4445
}
4546

4647
pre {
47-
display: none;
4848
width: 100%;
4949
box-sizing: border-box;
50+
min-height: 60px;
51+
}
52+
53+
pre.hidden {
54+
display: none;
5055
}
5156

5257
.error {
@@ -144,14 +149,14 @@ <h4 class="schema-header">Desired schema</h4>
144149

145150
<div class="diff-section">
146151
<div class="diff-label">Up (current → desired)</div>
147-
<pre id="outputUp"></pre>
148-
<pre id="errorUp" class="error"></pre>
152+
<pre id="outputUp" class="language-sql">&nbsp;</pre>
153+
<pre id="errorUp" class="error hidden"></pre>
149154
</div>
150155

151156
<div class="diff-section">
152157
<div class="diff-label">Down (desired → current)</div>
153-
<pre id="outputDown"></pre>
154-
<pre id="errorDown" class="error"></pre>
158+
<pre id="outputDown" class="language-sql">&nbsp;</pre>
159+
<pre id="errorDown" class="error hidden"></pre>
155160
</div>
156161

157162
<section>
@@ -163,11 +168,13 @@ <h2>How It Works</h2>
163168
</section>
164169

165170
<footer>
166-
<p id="version"></p>
171+
<p id="version">&nbsp;</p>
167172
<p>
168173
<a href="https://github.com/sqldef/sqldef">https://github.com/sqldef/sqldef</a>
169174
</p>
170175
</footer>
176+
<script src="https://cdnjs.cloudflare.com/ajax/libs/prism/1.30.0/components/prism-core.min.js"></script>
177+
<script src="https://cdnjs.cloudflare.com/ajax/libs/prism/1.30.0/components/prism-sql.min.js"></script>
171178
<script src="app.mjs" type="module"></script>
172179
</body>
173180
</html>

0 commit comments

Comments
 (0)