Can I simplify this lambda?

[ajtruckle]

As you can see from the code below, I use find_element to drill down to tthe desired week in the XML file:

auto pWeek = tinyxml2::find_element(doc, stdWeekPath);
if (pWeek != nullptr)
{
	auto UpdateAssignForWeek = [this, listMidweekAssign, pWeek, pEntry](int iAssign, const char* strElement, MWBAuto::SetAssignNameFunc fncSetAssignName)
	{
		if (listMidweekAssign.at(iAssign)) // Host
		{
			const tinyxml2::XMLElement* pElement = pWeek->FirstChildElement(strElement);
			if (pElement == nullptr)
			{
				AfxThrowMemoryException();
			}

			CString strNameToUse;
			strNameToUse = CA2CT(pElement->GetText(), CP_UTF8);
			(pEntry->*fncSetAssignName)(strNameToUse);
		}
	};

	UpdateAssignForWeek(0, kVideoConferenceHost, &CChristianLifeMinistryEntry::SetVideoHost);
	UpdateAssignForWeek(1, kVideoConferenceCohost, &CChristianLifeMinistryEntry::SetVideoCohost);
	UpdateAssignForWeek(2, kChairman, &CChristianLifeMinistryEntry::SetChairman);

	if (iDate == m_iDateIndex)
	{
		DisplayMeetingForDate();
	}
}

But can the lambda be simplified? Where it get the text of the sub element? Do you have a helper for that? Sorry if I missed in the sample.

Thank you.

[ajtruckle]

So far I have made one minor change:

auto UpdateAssignForWeek = [this, listMidweekAssign, pWeek, pEntry](int iAssign, std::string strElement, MWBAuto::SetAssignNameFunc fncSetAssignName)
{
	if (listMidweekAssign.at(iAssign))
	{
		auto pElement = tinyxml2::find_element(pWeek, strElement);
		if (pElement == nullptr)
		{
			AfxThrowMemoryException();
		}

		CString strNameToUse;
		strNameToUse = CA2CT(pElement->GetText(), CP_UTF8);
		(pEntry->*fncSetAssignName)(strNameToUse);
	}
};

The lambda now uses find_element too, relative to pWeek. And it is passed a std::string for the XPath. I thought this would be better for issue #9 that I have raised. Once I have confirmation about the correct XPath for that issue I could just re-use my lambda.

[ajtruckle]

This simplifies it by one line of code and seems to work well:

CString strNameToUse(tinyxml2::text(pElement).c_str());
//strNameToUse = CA2CT(pElement->GetText(), CP_UTF8);
(pEntry->*fncSetAssignName)(strNameToUse);

My application is multilingual but have not tested in them (like Japanese etc.).

[ajtruckle]

This is related to #7. In the end I could not use the text helper function directly.