From 05c8db92e142294326e46f6f2a2016434538de3f Mon Sep 17 00:00:00 2001 From: Jack Yuan Date: Tue, 16 Dec 2025 10:38:02 -0800 Subject: [PATCH 1/3] feat: add api check to github workflow --- .github/workflows/pr-and-push.yml | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/.github/workflows/pr-and-push.yml b/.github/workflows/pr-and-push.yml index b558943dd..0143ecffa 100644 --- a/.github/workflows/pr-and-push.yml +++ b/.github/workflows/pr-and-push.yml @@ -17,3 +17,15 @@ jobs: contents: read with: ref: ${{ github.event.pull_request.head.sha }} + + check-api: + runs-on: ubuntu-latest + permissions: + contents: read + steps: + - uses: actions/checkout@v5 + with: + fetch-depth: 0 # We the need the full Git history. + - uses: astral-sh/setup-uv@v6 + # The following command will compare current changes to latest tag. + - run: uvx griffe check --search src --format github strands-agents \ No newline at end of file From a8e361aa0ef4ea56e2859720371a85c00ed7faa7 Mon Sep 17 00:00:00 2001 From: Jack Yuan <94985218+JackYPCOnline@users.noreply.github.com> Date: Tue, 16 Dec 2025 12:56:52 -0800 Subject: [PATCH 2/3] Update pr-and-push.yml fix package name. --- .github/workflows/pr-and-push.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/pr-and-push.yml b/.github/workflows/pr-and-push.yml index 0143ecffa..267b4436f 100644 --- a/.github/workflows/pr-and-push.yml +++ b/.github/workflows/pr-and-push.yml @@ -28,4 +28,4 @@ jobs: fetch-depth: 0 # We the need the full Git history. - uses: astral-sh/setup-uv@v6 # The following command will compare current changes to latest tag. - - run: uvx griffe check --search src --format github strands-agents \ No newline at end of file + - run: uvx griffe check --search src --format github strands From 6fef1fa711fb0649575389f938b78eb0cb0ae170 Mon Sep 17 00:00:00 2001 From: Jack Yuan Date: Fri, 19 Dec 2025 12:38:46 -0800 Subject: [PATCH 3/3] fix: Compare against the actual base of the PR or the previous commit on push, rather than the latest tag --- .github/workflows/pr-and-push.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/pr-and-push.yml b/.github/workflows/pr-and-push.yml index 267b4436f..c71c2eb4c 100644 --- a/.github/workflows/pr-and-push.yml +++ b/.github/workflows/pr-and-push.yml @@ -27,5 +27,4 @@ jobs: with: fetch-depth: 0 # We the need the full Git history. - uses: astral-sh/setup-uv@v6 - # The following command will compare current changes to latest tag. - - run: uvx griffe check --search src --format github strands + - run: uvx griffe check --search src --format github strands --against "${{ github.event.pull_request.base.sha || github.event.before || 'HEAD' }}"