-
Notifications
You must be signed in to change notification settings - Fork 14
Description
To me it seems odd to pass query params as an enum since they are already in the URL we sent to the lib. My problem is that I have a webserver w/large gzipped assets that only allows me to download with a bad query string.
ie. &Expires=1687269643&Signature=A0rGvq2fJZXfmDDJK-gut5jntqQ9lDFDOMH~WEov8t8z3R174eC0QXDsBR9sNeIRENR2AsWobhscdk8pcHD6uCUeQqRC05Opkr3QYrh-xJyoOm-0ZCpQLIeVMHFAUDyaDJkFx4ERNRU-piLISaKzbJzUl15zqUkaV-T5dcCxRuuLtWssY1tnZS-X3b95HZGqBLbyXiltsEj8s~njxiLPhf26uQajE3IWp-YXu4oS21Ab0onNzZmUTDIhvt3rL-c4MBE6P5lys-5biYgONAJtIVN~JWGUexB2ZdLejk0KCVSlM4R71Ou7UoIAesAX5ZYZT~MhIqzQzEVZgiPMzgnaZg__&Key-Pair-Id=K27TQMT39R1C8A
I just re-implement the library but it looks like this is still a bit raw and depending on the webserver we don't get valid responses so we have to use cURL as a fallback. I've had cases where the file I'm trying to get needs to be resumed in Chrome after failure. I don't expect this lib to handle that case. I'm just saying that in some cases we are doomed.