Set strict parameter of in_array to true where possible

alexandre-daubois · alexandre-daubois · commit ef0127112da7 · 2023-12-14T11:33:29.000+01:00
diff --git a/Path.php b/Path.php
@@ -668,7 +668,7 @@ public static function join(string ...$paths): string
             }
 
             // Only add slash if previous part didn't end with '/' or '\'
-            if (!\in_array(substr($finalPath, -1), ['/', '\\'])) {
+            if (!\in_array(substr($finalPath, -1), ['/', '\\'], true)) {
                 $finalPath .= '/';
             }
 
diff --git a/Tests/FilesystemTest.php b/Tests/FilesystemTest.php
@@ -167,7 +167,7 @@ public function testCopyCreatesTargetDirectoryIfItDoesNotExist()
      */
     public function testCopyForOriginUrlsAndExistingLocalFileDefaultsToCopy()
     {
-        if (!\in_array('https', stream_get_wrappers())) {
+        if (!\in_array('https', stream_get_wrappers(), true)) {
             $this->markTestSkipped('"https" stream wrapper is not enabled.');
         }
         $sourceFilePath = 'https://symfony.com/images/common/logo/logo_symfony_header.png';

Original file line number	Diff line number	Diff line change
`@@ -668,7 +668,7 @@ public static function join(string ...$paths): string`
`668`	`668`	`}`
`669`	`669`
`670`	`670`	`// Only add slash if previous part didn't end with '/' or '\'`
`671`		`- if (!\in_array(substr($finalPath, -1), ['/', '\\'])) {`
	`671`	`+ if (!\in_array(substr($finalPath, -1), ['/', '\\'], true)) {`
`672`	`672`	`$finalPath .= '/';`
`673`	`673`	`}`
`674`	`674`
Original file line number	Diff line number	Diff line change
`@@ -167,7 +167,7 @@ public function testCopyCreatesTargetDirectoryIfItDoesNotExist()`
`167`	`167`	`*/`
`168`	`168`	`public function testCopyForOriginUrlsAndExistingLocalFileDefaultsToCopy()`
`169`	`169`	`{`
`170`		`- if (!\in_array('https', stream_get_wrappers())) {`
	`170`	`+ if (!\in_array('https', stream_get_wrappers(), true)) {`
`171`	`171`	`$this->markTestSkipped('"https" stream wrapper is not enabled.');`
`172`	`172`	`}`
`173`	`173`	`$sourceFilePath = 'https://symfony.com/images/common/logo/logo_symfony_header.png';`