Remove uniqid() from tempnam() calls

Author: derrabus

Factory/HttpFoundationFactory.php

@@ -104,7 +104,7 @@ private function createUploadedFile(UploadedFileInterface $psrUploadedFile): Upl
      */
     protected function getTemporaryPath(): string
     {
-        return tempnam(sys_get_temp_dir(), uniqid('symfony', true));
+        return tempnam(sys_get_temp_dir(), 'symfony');
     }
 
     public function createResponse(ResponseInterface $psrResponse, bool $streamed = false): Response

Tests/Factory/HttpFoundationFactoryTest.php

@@ -198,7 +198,7 @@ public function testCreateUploadedFileWithError()
 
     private function createUploadedFile(string $content, int $error, string $clientFileName, string $clientMediaType): UploadedFile
     {
-        $filePath = tempnam($this->tmpDir, uniqid());
+        $filePath = tempnam($this->tmpDir, 'sftest');
         file_put_contents($filePath, $content);
 
         return new UploadedFile($filePath, filesize($filePath), $error, $clientFileName, $clientMediaType);

Tests/Factory/PsrHttpFactoryTest.php

@@ -131,7 +131,7 @@ public function testGetContentCanBeCalledAfterRequestCreation()
 
     private function createUploadedFile(string $content, string $originalName, string $mimeType, int $error): UploadedFile
     {
-        $path = tempnam($this->tmpDir, uniqid());
+        $path = $this->createTempFile();
         file_put_contents($path, $content);
 
         return new UploadedFile($path, $originalName, $mimeType, $error, true);
@@ -182,7 +182,7 @@ public function testCreateResponseFromStreamed()
 
     public function testCreateResponseFromBinaryFile()
     {
-        $path = tempnam($this->tmpDir, uniqid());
+        $path = $this->createTempFile();
         file_put_contents($path, 'Binary');
 
         $response = new BinaryFileResponse($path);
@@ -194,7 +194,7 @@ public function testCreateResponseFromBinaryFile()
 
     public function testCreateResponseFromBinaryFileWithRange()
     {
-        $path = tempnam($this->tmpDir, uniqid());
+        $path = $this->createTempFile();
         file_put_contents($path, 'Binary');
 
         $request = new Request();
@@ -287,4 +287,9 @@ private static function buildHttpMessageFactory(): PsrHttpFactory
 
         return new PsrHttpFactory($factory, $factory, $factory, $factory);
     }
+
+    private function createTempFile(): string
+    {
+        return tempnam($this->tmpDir, 'sftest');
+    }
 }

Tests/Functional/CovertTest.php

@@ -217,7 +217,7 @@ public static function responseProvider(): array
 
     private static function createUploadedFile(string $content, string $originalName, string $mimeType, int $error): UploadedFile
     {
-        $path = tempnam(sys_get_temp_dir(), uniqid());
+        $path = tempnam(sys_get_temp_dir(), 'sftest');
         file_put_contents($path, $content);
 
         return new UploadedFile($path, $originalName, $mimeType, $error, true);