improved environment

Author: dmitriy

.circleci/config.yml

@@ -31,6 +31,12 @@ jobs:
           command: |
             make report-code-coverage
 
+      - run:
+          name: Check coding standard & CodeSniffer
+          command: |
+            make ecs
+            make phpcs
+
       - store_artifacts:
           path: reports
 

.editorconfig

@@ -11,5 +11,8 @@ trim_trailing_whitespace = true
 [*.md]
 trim_trailing_whitespace = false
 
-[*.{yml,yaml}]
+[*.yml]
 indent_size = 2
+
+[{composer.json,Makefile}]
+indent_style = tab

.gitattributes

@@ -3,3 +3,6 @@
 *.scss linguist-vendored
 *.js linguist-vendored
 CHANGELOG.md export-ignore
+docs/postman/symfony.postman_collection.json binary
+tools/**/composer.lock binary
+composer.lock binary

.github/workflows/ci.yml

@@ -34,5 +34,9 @@ jobs:
               run: make seed
             - name: Run test suite
               run: make phpunit
+            - name: Run coding standard
+              run: make ecs
+            - name: Run codeSniffer
+              run: make phpcs
             - name: Stop the docker images
               run: make stop-test

.gitignore

@@ -7,6 +7,7 @@
 /storage/*.key
 /storage/mysql-data/
 /vendor
+/tools/**/vendor
 Homestead.yaml
 Homestead.json
 .env
@@ -17,4 +18,4 @@ reports/*
 !reports/.gitkeep
 npm-debug.log
 yarn-error.log
-.phpunit.result.cache
+.phpunit.result.cache

Dockerfile

@@ -30,14 +30,17 @@ RUN apt-get update && apt-get upgrade -y && apt-get install -y \
       cron \
       libzip-dev \
     && docker-php-ext-configure pdo_mysql --with-pdo-mysql=mysqlnd \
+    && docker-php-ext-configure intl \
     && docker-php-ext-install \
       pdo_mysql \
+      sockets \
       intl \
-      zip && \
-      rm -fr /tmp/* && \
-      rm -rf /var/list/apt/* && \
-      rm -r /var/lib/apt/lists/* && \
-      apt-get clean
+      opcache \
+      zip \
+    && rm -rf /tmp/* \
+    && rm -rf /var/list/apt/* \
+    && rm -rf /var/lib/apt/lists/* \
+    && apt-get clean
 
 # create document root
 RUN mkdir -p $APP_HOME/public
@@ -49,13 +52,15 @@ RUN chown -R www-data:www-data $APP_HOME
 COPY ./docker/$BUILD_ARGUMENT_ENV/www.conf /usr/local/etc/php-fpm.d/www.conf
 COPY ./docker/$BUILD_ARGUMENT_ENV/php.ini /usr/local/etc/php/php.ini
 
-# install Xdebug in case development environment
+# install Xdebug in case dev/test environment
 COPY ./docker/general/do_we_need_xdebug.sh /tmp/
 COPY ./docker/dev/xdebug.ini /tmp/
 RUN chmod u+x /tmp/do_we_need_xdebug.sh && /tmp/do_we_need_xdebug.sh
 
 # install composer
-RUN curl -sS https://getcomposer.org/installer | php -- --install-dir=/usr/bin/ --filename=composer
+COPY --from=composer:latest /usr/bin/composer /usr/bin/composer
+RUN chmod +x /usr/bin/composer
+ENV COMPOSER_ALLOW_SUPERUSER 1
 
 # add supervisor
 RUN mkdir -p /var/log/supervisor
@@ -76,8 +81,8 @@ COPY --chown=www-data:www-data . $APP_HOME/
 COPY --chown=www-data:www-data .env.$ENV $APP_HOME/.env
 
 # install all PHP dependencies
-RUN if [ "$BUILD_ARGUMENT_ENV" = "dev" ] || [ "$BUILD_ARGUMENT_ENV" = "test" ]; then composer install --no-interaction --no-progress; \
-    else composer install --no-interaction --no-progress --no-dev; \
+RUN if [ "$BUILD_ARGUMENT_ENV" = "dev" ] || [ "$BUILD_ARGUMENT_ENV" = "test" ]; then COMPOSER_MEMORY_LIMIT=-1 composer install --optimize-autoloader --no-interaction --no-progress; \
+    else COMPOSER_MEMORY_LIMIT=-1 composer install --optimize-autoloader --no-interaction --no-progress --no-dev; \
     fi
 
 USER root

Makefile

@@ -62,13 +62,13 @@ wait-for-db:
 	@make exec cmd="php artisan db:wait"
 
 composer-install-prod:
-	@make exec cmd="composer install --no-dev"
+	@make exec-bash cmd="COMPOSER_MEMORY_LIMIT=-1 composer install --optimize-autoloader --no-dev"
 
 composer-install:
-	@make exec cmd="composer install"
+	@make exec-bash cmd="COMPOSER_MEMORY_LIMIT=-1 composer install --optimize-autoloader"
 
 composer-update:
-	@make exec cmd="composer update"
+	@make exec-bash cmd="COMPOSER_MEMORY_LIMIT=-1 composer update"
 
 info:
 	@make exec cmd="php artisan --version"

app/Console/Kernel.php

@@ -12,30 +12,25 @@ class Kernel extends ConsoleKernel
      *
      * @var array
      */
-    protected $commands = [
-        //
-    ];
+    protected $commands = [];
 
     /**
      * Define the application's command schedule.
      *
      * @param  \Illuminate\Console\Scheduling\Schedule  $schedule
-     * @return void
      */
-    protected function schedule(Schedule $schedule)
+    protected function schedule(Schedule $schedule): void
     {
         // $schedule->command('inspire')
         //          ->hourly();
     }
 
     /**
      * Register the commands for the application.
-     *
-     * @return void
      */
-    protected function commands()
+    protected function commands(): void
     {
-        $this->load(__DIR__.'/Commands');
+        $this->load(__DIR__ . '/Commands');
 
         require base_path('routes/console.php');
     }

app/Exceptions/Handler.php

@@ -12,9 +12,7 @@ class Handler extends ExceptionHandler
      *
      * @var array
      */
-    protected $dontReport = [
-        //
-    ];
+    protected $dontReport = [];
 
     /**
      * A list of the inputs that are never flashed for validation exceptions.
@@ -30,11 +28,10 @@ class Handler extends ExceptionHandler
      * Report or log an exception.
      *
      * @param  \Exception  $exception
-     * @return void
      *
      * @throws \Exception
      */
-    public function report(Exception $exception)
+    public function report(Exception $exception): void
     {
         parent::report($exception);
     }

app/Http/Controllers/Auth/ConfirmPasswordController.php

@@ -30,8 +30,6 @@ class ConfirmPasswordController extends Controller
 
     /**
      * Create a new controller instance.
-     *
-     * @return void
      */
     public function __construct()
     {