Python bindings fail to build in current release

[chuckatkins]

The SWIG python bindings fail with the following error:

[build/v2.1.11.1]$ cmake -DBUILD_PYTHON_WRAPPER=ON ../../source/v2.1.11.1
...
[build/v2.1.11.1]$ make
...
[ 97%] Building CXX object swig/CMakeFiles/pysz.dir/CMakeFiles/pysz.dir/pyszPYTHON_wrap.cxx.o
In file included from /home/tmpuser/sz/build/swig/CMakeFiles/pysz.dir/pyszPYTHON_wrap.cxx:2844:0:
/home/tmpuser/sz/source/swig/pysz.h: In member function ‘exafelSZ_params* ExaFELConfigBuilder::build()’:
/home/tmpuser/sz/source/swig/pysz.h:90:13: error: ‘exafelSZ_params’ has no member named ‘peaks’
     params->peaks = new uint8_t [peaks.size()];
             ^
/home/tmpuser/sz/source/swig/pysz.h:92:59: error: ‘exafelSZ_params’ has no member named ‘peaks’
     std::copy(std::begin(peaks), std::end(peaks), params->peaks);
                                                           ^
/home/tmpuser/sz/source/swig/pysz.h: In static member function ‘static void ExaFELConfigBuilder::free(exafelSZ_params*)’:
/home/tmpuser/source/swig/pysz.h:108:22: error: ‘exafelSZ_params’ has no member named ‘peaks’
     delete[] params->peaks;
                      ^
make[2]: *** [swig/CMakeFiles/pysz.dir/CMakeFiles/pysz.dir/pyszPYTHON_wrap.cxx.o] Error 1
make[1]: *** [swig/CMakeFiles/pysz.dir/all] Error 2
make: *** [all] Error 2
[build/v2.1.11.1]$ 

[robertu94]

@chuckatkins this was fixed in commit 56e7b23. Please try the tip of master. I'll follow up with Sheng about long term solutions.

You may also be interested in the LibPressio python bindings for SZ. I wrote both of them, but the libpressio python bindings are faster, safer in some edge cases, and support other compressors, and are easier to maintain.

[chuckatkins]

Do you know what versions are affected by the bug? I'd like to place a conflict in the spack package for conflicts("+python", when="@known.broken.vers").

[robertu94]

The commit that broke things is the one that created 2.1.11.1, and I checked all of the versions going back to 2.0.2.0 and none of them broke things. @ me on the PR to spack, and I will approve the conflicts("+python", when="@2.1.11.1") as a maintainer.