How will latest changes to devise_crowd work with hippo

[paloc]

It just occurred to me that devise_crowd gem is also used by hippo. I'm not sure how this will work with the latest changes related to removing Crowd from user authentication process. In fact, I don't think this will work at all. Do we need a separate devise_crowd version for hippo?

[dominiksteiner]

@paloc indeed I bumped into that one too, as in yolk it will simply use the db lookup but for hippo we would need to use a yolk_client to validate the password and token vs yolk?

[paloc]

@dominiksteiner I think so. Although that brings up a question whether hippo even needs device_crowd gem. Not sure how it's integrated. It might be that we don't need a gem at all and can add a simpler solution using yolk_client?

[dominiksteiner]

@paloc indeed that sounds like a better plan

[dominiksteiner]

@paloc what should we do with the User model in hippo? Currently it is used by devise at least in hippo but as we authenticate via yolk we are basically duplicating the user model from there?

Also though there seems to be login views in hippo itself I guess those are not used as they don't seem to be functional or do we need to fix that too?

[paloc]

@dominiksteiner I'll have to review in detail. I believe the User model in hippo is used little differently. Its primary purpose is for ACL authorization, it doesn't do any authentication or real user management. And I'm not sure we make use of the ACL there at all. I'll take a closer look, but that's my current understanding.