Authorisation sometimes returns a 303 response

[HughMacdonald]

I've been having some issues with my app today, and I've tracked it down to the auth url returning a 303.

What I end up seeing is this:

requests.exceptions.MissingSchema: Invalid URL '/u/login?state=<redacted>': No scheme supplied. Perhaps you meant https:///u/login?state=<redacted>?

This is coming back from this line:

WeConnect-python/weconnect/auth/vw_web_session.py

Line 101 in 7ffb9be

url = response.headers['Location']

The location coming back with this 302 response is only a relative URL, so on the second loop around, it raises the exception listed above.

[HughMacdonald]

I tried replacing the top of _get_login_form() with this:

    def _get_login_form(self, url: str) -> HTMLFormParser:
        original_url = urlparse(url)
        while True:
            parsed_url = urlparse(url)
            if parsed_url.netloc == "":
                url = original_url.scheme + "://" + original_url.netloc + url
            response = self.websession.get(url, allow_redirects=False)

Which gives it a valid URL to call, but I'm then getting:

weconnect.errors.APICompatibilityError: Could not find all required input fields on login page

[HughMacdonald]

Going to the login page manually, and inspecting the page, I can find the form, but it doesn't seem to have an id, which may be a change on their end.

I'm seeing the form defined as:

<form method="POST" class="cfdd10f44 c6dbb2847" data-form-primary="true" data-disable-html-validations="true" novalidate="">

[pho2Github]

I have the same issue since today 21:45 german time.

[HughMacdonald]

For reference, my system stopped talking to my car at 09:40 UTC

[tillsteinbach]

We are working on a fix here: tillsteinbach/CarConnectivity-connector-volkswagen#61 once that is done I will back port the changes to WeConnect-python.

[HughMacdonald]

Amazing - thanks for the update

[tillsteinbach]

Problem is found and fixed in CarConnectivity, I need some time to back port the changes here. Hope to get it done by the end of the week.

[HughMacdonald]

Great.

I've actually mostly transitioned my project over to CarConnectivity, which gives me more flexibility, but this will be useful for others still using this package

[tillsteinbach]

Please try installing pip install weconnect==0.60.9a1 and report back if this is fixing the issue

[pho2Github]

Thanks a lot. It‘s working for me!

[forgeorge]

The fix fixes the issue for me, too. Thanks!

[Domoberry]

I can also confirm it is working again.
For reference (I'm not PiOS specialist, so to make sure 'm referring to the correct versions etc):

pi@rpi4domoticz:~ $ /usr/bin/python3 -m pip show weconnect | grep Version
Version: 0.60.9a1

pi@rpi4domoticz:~ $ /usr/bin/python3 -c "import weconnect; print(weconnect.__file__)"
/usr/local/lib/python3.9/dist-packages/weconnect/__init__.py

pi@rpi4domoticz:~ $ systemctl cat weconnect-mqtt.service | grep User=
User=pi

pi@rpi4domoticz:~ $ sudo systemctl restart weconnect-mqtt

pi@rpi4domoticz:~ $ weconnect-mqtt --version
weconnect-mqtt 0.49.2 (using WeConnect-python 0.60.9a1)
```
`

Thanks!