-
Notifications
You must be signed in to change notification settings - Fork 0
Closed
Labels
Description
Problem
The codebase inconsistently uses 'latlong' and 'coordinates' to identify coordinate-based targets, which can cause confusion and potential bugs.
Root Cause Analysis
From AGENT_TASKS.md analysis:
- The codebase inconsistently uses
'latlong'to identify coordinate-based targets - This inconsistency exists across multiple files and could lead to bugs
- A standardization to
'coordinates'was planned but not implemented
Impact
- Technical Debt: Inconsistent naming makes code harder to maintain
- Potential Bugs: Different parts of code might use different identifiers
- Developer Confusion: New developers may not know which identifier to use
- Future Issues: Could cause problems when adding new coordinate-related features
Files Involved
Based on AGENT_TASKS.md, these files need investigation and potential updates:
src/cogs/command_handler.pysrc/cogs/runner.pysrc/models.py- Any other files that reference coordinate target types
Proposed Solution
Systematically replace all instances of 'latlong' with 'coordinates' throughout the codebase:
- Search: Find all occurrences of
'latlong'in the codebase - Review: Ensure each occurrence is actually referring to coordinate target types
- Replace: Update to use
'coordinates'consistently - Test: Ensure all functionality still works with the new identifier
- Documentation: Update any documentation that references the old identifier
Acceptance Criteria
- All code uses
'coordinates'consistently for coordinate-based targets - No references to
'latlong'remain in the codebase - All tests pass with the new identifier
- Database entries are updated if necessary
- Documentation reflects the standardized terminology
Priority
MEDIUM - This is technical debt that should be addressed to prevent future issues, but doesn't block current functionality.