Skip to content

Standardize coordinate target type: 'latlong' vs 'coordinates' inconsistency #70

@timothyfroehlich

Description

@timothyfroehlich

Problem

The codebase inconsistently uses 'latlong' and 'coordinates' to identify coordinate-based targets, which can cause confusion and potential bugs.

Root Cause Analysis

From AGENT_TASKS.md analysis:

  • The codebase inconsistently uses 'latlong' to identify coordinate-based targets
  • This inconsistency exists across multiple files and could lead to bugs
  • A standardization to 'coordinates' was planned but not implemented

Impact

  • Technical Debt: Inconsistent naming makes code harder to maintain
  • Potential Bugs: Different parts of code might use different identifiers
  • Developer Confusion: New developers may not know which identifier to use
  • Future Issues: Could cause problems when adding new coordinate-related features

Files Involved

Based on AGENT_TASKS.md, these files need investigation and potential updates:

  • src/cogs/command_handler.py
  • src/cogs/runner.py
  • src/models.py
  • Any other files that reference coordinate target types

Proposed Solution

Systematically replace all instances of 'latlong' with 'coordinates' throughout the codebase:

  1. Search: Find all occurrences of 'latlong' in the codebase
  2. Review: Ensure each occurrence is actually referring to coordinate target types
  3. Replace: Update to use 'coordinates' consistently
  4. Test: Ensure all functionality still works with the new identifier
  5. Documentation: Update any documentation that references the old identifier

Acceptance Criteria

  • All code uses 'coordinates' consistently for coordinate-based targets
  • No references to 'latlong' remain in the codebase
  • All tests pass with the new identifier
  • Database entries are updated if necessary
  • Documentation reflects the standardized terminology

Priority

MEDIUM - This is technical debt that should be addressed to prevent future issues, but doesn't block current functionality.

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions