Capitalization for SQL keywords

[pakricard]

Hi:

Some recent commits have been changing some SQL keywords from capital letters to lowercase, as: and, or, case...

According to https://weberp.org/CodingStandards.html we should use all capitals for keywords,.

I think changing these keywords to lowercase makes the code less readable, and revising or merging commits way more complex as the number of lines involved increases.

R

[pakricard]

Similar to this, we have PHP structures if () with:

• AND, OR
• and, or
• &&, ||

According to https://weberp.org/CodingStandards.html the standard is lowercase, but most of the scripts use uppercase.

R

[gggeek]

The situation with AND/OR is a bit messy...

My personal pref would be to use || and &&, as is most common in most other php projects.

But given the current state of the code, using AND/OR for SQL and and/or for php is probably better.

The though thing about this one is that it is hard to script/automate such reformatting, as it is difficult to write a parser guaranteed to be able to tell apart php code from sql code...

[timschofield]

It should be lower case for PHP code, and upper case for SQL code. We have always tried to avoid || and && though I know some have slipped in.

If these recent commits were mine, I apologise :)

[gggeek]

We have always tried to avoid || and && though I know some have slipped in.

Just a note regarding this, in case anyone stumbles on this ticket: there is a difference between AND/OR and &&/||, and it is the order of precedence wrt. other operators. AND/OR have lower precedence (see https://www.php.net/manual/en/language.operators.precedence.php)

[timschofield]

Yes, I am aware of this, and surprisingly it has been discussed before. However we have always agreed to not use || and &&

Tim