-
Notifications
You must be signed in to change notification settings - Fork 1
Open
Labels
good first issueGood for newcomersGood for newcomerskind/I&CCode, Infrastructure, Tests, everything that is not feature related, but more code relatedCode, Infrastructure, Tests, everything that is not feature related, but more code relatedsize/ST-shit size for tasks that take less than a dayT-shit size for tasks that take less than a daytype/enhancementNew feature or improvement that doesn't add value to final userNew feature or improvement that doesn't add value to final user
Description
Right now, we are using ValueError everywhere as internal exceptions. This has a few problems:
- When testing, if we are looking for a ValueError (meaning we are testing a failing case) and get an actual ValueError (we are accessing a type the wrong way), the test will pass, but we will miss the difference
- When retrying, retries can mask our errors instead of exposing it the first time.
Metadata
Metadata
Assignees
Labels
good first issueGood for newcomersGood for newcomerskind/I&CCode, Infrastructure, Tests, everything that is not feature related, but more code relatedCode, Infrastructure, Tests, everything that is not feature related, but more code relatedsize/ST-shit size for tasks that take less than a dayT-shit size for tasks that take less than a daytype/enhancementNew feature or improvement that doesn't add value to final userNew feature or improvement that doesn't add value to final user