Skip to content
This repository was archived by the owner on Jan 5, 2024. It is now read-only.
This repository was archived by the owner on Jan 5, 2024. It is now read-only.

When the periodic advertise fails continuously, we should kill the process #468

@prashantv

Description

@prashantv

We saw an issue where the peer list was polluted with non-Hyperbahn peers (#464) and the periodic advertise kept failing, but the process stayed up.

At this point the process was hosed since all calls were failing. If some K advertises fail in a row, it probably means we should stop receiving requests.

Here is tchannel-go's implementation:
https://github.com/uber/tchannel-go/blob/dev/hyperbahn/advertise.go#L31

If we get 5 consecutive failures, we will fatal (unless the user sets a custom FailStrategy, the default is to fatal).

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions