Skip to content

Data from the underlying API not exposed by SDK classes #153

@neilbenn

Description

@neilbenn
  1. client.qualifications().checkEligibility() accepts an option to expand redeemables, but the expanded values do not appear to be available in CheckEligibilityResponse.getRedeemable().getData().

     private static final Option EXPAND_REDEEMABLES_OPTION = Option.builder().expand(List.of(Expand.REDEEMABLE)).build();
     ...
      Customer customer = toVoucherifyCustomer(company);
     CheckEligibility check = CheckEligibility
             .builder()
             .customer(customer)
             .scenario(Scenario.AUDIENCE_ONLY)
             .option(EXPAND_REDEEMABLES_OPTION)
             .build();
    
     CheckEligibilityResponse eligibility = client.qualifications().checkEligibility(check);
    

RedeemableDataResponse does not have a getName or getBanner ... even though these values are returned in the underlying API call.

  1. client.stackables().validate does not appear to expose the applied_discount_amount property in the OrderResponse class, even though the value is present in the underlying API call to /v1/validations. The equivalent OrderItemResponse.getAppliedDiscountAmount() is there, but OrderResponse just has getDiscountAmount() and no getAppliedDiscountAmount().

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions