-
Notifications
You must be signed in to change notification settings - Fork 95
Open
Description
Current Status
- Last PyPI release: v1.0.4.1 (August 1, 2024)
- Japanese ITN added: November 11, 2024 (PR Support Japanese TN&ITN #281)
- Time since last release: ~17 months
Issues Preventing pip install from GitHub
-
setup.py bug (line 18):
python
version = sys.argv[-1].split("=")[1] # IndexError if no version arg
This breaks pip install git+https://github.com/... -
Missing Japanese data in package_data:
'itn': ['.fst', 'chinese/data//.tsv'], # Missing: 'japanese/data//*.tsv'
Request
Could you please:
- Fix setup.py to handle version gracefully (e.g., default to "0.0.0" or read from a VERSION file)
- Add Japanese data files to package_data
- Publish a new release to PyPI
Impact
Users wanting Japanese ITN must manually clone repo, run python setup.py install version=X.X.X, and copy data files - this breaks CI/CD pipelines.
Thank you for the great project! 🙏
Metadata
Metadata
Assignees
Labels
No labels