From ae69825114861759d4b1152d22070f3912b1a0bc Mon Sep 17 00:00:00 2001 From: TrellixVulnTeam Date: Thu, 27 Oct 2022 17:00:07 +0000 Subject: [PATCH] Adding tarfile member sanitization to extractall() --- vocalizer-backend/vocalizer/views.py | 21 ++++++++++++++++++++- 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/vocalizer-backend/vocalizer/views.py b/vocalizer-backend/vocalizer/views.py index 600ee0ce..a95819c7 100644 --- a/vocalizer-backend/vocalizer/views.py +++ b/vocalizer-backend/vocalizer/views.py @@ -212,5 +212,24 @@ def upload_result(request, hash): with open(archive_path, 'wb') as archive: archive.write(data) with tarfile.open(archive_path) as tar: - tar.extractall(audio_file.paths.root) + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner=numeric_owner) + + + safe_extract(tar, audio_file.paths.root) return _success()