[BE] Use native node.js promise

[alexanmtz]

✏️ Summary

Replace Bluebird promises for native js promises in all modules

📋 Description

We're using Bluebird promises in modules like here: https://github.com/worknenjoy/gitpay/blob/master/modules/users/userAccount.js, and we want to replace with native JS promises as discussed here:
#978

We have a lot of API tests, so the tests should continue to pass, and no extra tests are needed for this.

🔍 Steps to Reproduce (or trigger)

1. Run the project locally
2. Run the Node server
3. Run the front-end server
4. Create a user

Check how to run the project locally here: https://github.com/worknenjoy/gitpay/blob/master/README.md

✅ Expected Behavior

The tests should continue to pass, and the platform should continue working as it is today

🛠️ Stack Affected

Node.js

💰 Is there a bounty for this issue?

No

📜 Bounty Details (if applicable)

This issue is not part of our bounty program and you should work on it as a contributor.

For starter contributor, it could be a good chance to get your PR reviewed and get some experience

[rogdevil]

assign it to me @alexanmtz i will do this : )

[alexanmtz]

Great @rogdevil , I will assign to you

[cipherravi]

@alexanmtz can we use async await instead promises or there is specific use case of promises

[rogdevil]

@alexanmtz can we use async await instead promises or there is specific use case of promises

Using async await or promise are dependent on how you want the flow to be if u want blocking flow u use async await if u want parallel execution u can use promise .... What you cannot do is replace promise entirely with async await. PS: async await is built on top of promise

Let me know why you feel async await is better subjectively

[cipherravi]

for better readability i guess and if there is any reason to use promise then only we should use like promise.all or something

apart from this i am facing issue to start frontend server , backend is working but frontend has some issues i guess dependency issues what best i can do to tackle

[rogdevil]

@cipherravi For issue related to running code please open a new Issue

as for readability again I would say it depends on the how you use it personally I wouldn't want to replace,

const getLatestTransaction = () => getCurrentUserID()
  .then(getUserFromID)
  .catch(handleNoUser)
  .then(getUserTransactions)
  .catch(handleNoTransactions)
  .then(transactions => transactions[transactions.length - 1]);

with

async function getLatestTransaction() {
  let user;
  try {
    const userID = await getCurrentUserID();
    user = await getUserFromID(userID);
  } catch (error) {
    user = await handleNoUser(error);
  }

  let transactions;
  try {
    transactions = await getUserTransactions(user);
  } catch (error) {
   transactions = await handleNoTransactions(error);
  }

  return transactions[transactions.length - 1];
}

you can write readable code in any format if readability was so much of an issue for you in above syntax I think u should focus on Javascript basics again