From 194ff6139e31447f10affe231179c78f9ab0151f Mon Sep 17 00:00:00 2001 From: rehbergT <18345302+rehbergT@users.noreply.github.com> Date: Sat, 6 May 2023 00:27:48 +0200 Subject: [PATCH 1/2] fix error caused by assigning row names to object with dropped dimension --- R/bracket.r | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/R/bracket.r b/R/bracket.r index 5366e24..bc70a91 100644 --- a/R/bracket.r +++ b/R/bracket.r @@ -67,9 +67,9 @@ bracket_float32 = function(x, i, j, drop=TRUE) else d = bracket_float32_mat(x, i, j, drop=drop) - if (!is.null(rownames(x))) + if (!is.null(rownames(x)) & NROW(d) > 1 & NCOL(d) > 1) rownames(d) = rownames(x)[i] - if (!is.null(names(x))) + if (!is.null(names(x)) & length(d) > 1) names(d) = names(x)[j] float32(d) From 2a67ae204ae3150c06575b30766281464fb91be7 Mon Sep 17 00:00:00 2001 From: rehbergT <18345302+rehbergT@users.noreply.github.com> Date: Sat, 6 May 2023 00:57:48 +0200 Subject: [PATCH 2/2] prevent assigning undefined names --- R/bracket.r | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/R/bracket.r b/R/bracket.r index bc70a91..12ed589 100644 --- a/R/bracket.r +++ b/R/bracket.r @@ -69,7 +69,7 @@ bracket_float32 = function(x, i, j, drop=TRUE) if (!is.null(rownames(x)) & NROW(d) > 1 & NCOL(d) > 1) rownames(d) = rownames(x)[i] - if (!is.null(names(x)) & length(d) > 1) + if (!is.null(names(x)) & !missing(j) & length(d) > 1) names(d) = names(x)[j] float32(d)