Skip to content

Invalid logic of param setup #13

@gaospecial

Description

@gaospecial

in https://github.com/xia-lab/OptiLCMS/blob/0737baa52199c96733a5b7e7ff4fc57718f603f0/R/Optimize_params.R#L181C1-L190C10

        param[["ppm"]]<-round(p2$ppm,2);
        param[["noise"]]<-round(p2$noise,2);
        param[["prefilter"]]<-round(p2$prefilter,2);
        param[["value_of_prefilter"]]<-round(p2$value_of_prefilter,2);
        
        if(round(p2$ppm,2) < 1 | round(p2$ppm,2) > 100){
          param[["ppm"]] <- param[["ppm"]]; # Estimation failure, use the default instead !
        } else {
          param[["ppm"]] <- round(p2$ppm,2);
        }

even if 'Estimation failure', no default value is assigned to param[["ppm"]].

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions