Fix/shared history in streaming #1210
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng requests Change chat_history parameter type from Vec<Message> to Arc<RwLock<Vec<Message>>> in StreamChat trait and StreamingPromptRequest. This allows callers to retain access to the history and observe updates after the streaming request completes. Signed-off-by: Jiawei Zhao <Phoenix500526@163.com>
…f tokio Replace tokio::sync::RwLock with std::sync::RwLock for chat_history since the lock is never held across await points. This reduces async overhead for short-lived read/write operations. Signed-off-by: Jiawei Zhao <Phoenix500526@163.com>
Ensure user prompt and assistant response are added to history when streaming completes. Add test for shared ownership behavior. Signed-off-by: Jiawei Zhao <Phoenix500526@163.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1209