Skip to content

Conversation

@marino39
Copy link
Contributor

@marino39 marino39 commented Oct 2, 2025

No description provided.

@marino39 marino39 requested review from VojtechVitek and xiam October 2, 2025 08:29
@marino39 marino39 force-pushed the skip-hash-validation-for-gen-block-and-1 branch from 2f955c1 to c0613df Compare October 2, 2025 08:49
@marino39 marino39 changed the title skip: hash validation for block 0 and 1 skip: hash validation for block 1 Oct 2, 2025
Copy link
Contributor

@VojtechVitek VojtechVitek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment on lines +53 to +54
} else if strings.HasPrefix(c.String(DatasetPathFlag.Name), "/") {
fs = local.NewLocalFS("/")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this have to be an absolute path? Or can we allow relative paths ./ too?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The relative paths are handled by default. There was the issue where absolute path do not work.

@marino39 marino39 merged commit 6947107 into master Oct 3, 2025
1 check passed
@marino39 marino39 deleted the skip-hash-validation-for-gen-block-and-1 branch October 3, 2025 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants