fix: writer_with_verify_hash tries to get hash from block that hasn't… #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marino39
commented
Oct 21, 2025
|
|
||
| func (w *writerWithVerifyHash[T]) Write(ctx context.Context, b Block[T]) error { | ||
| // Skip if block is already written | ||
| if b.Number <= w.Writer.BlockNum() { |
Contributor
Author
There was a problem hiding this comment.
This is to keep behaviour in line with other Writer implementations.
marino39
commented
Oct 21, 2025
|
|
||
| // Validate parent hash | ||
| if b.Parent != w.prevHash { | ||
| w.prevHash = common.Hash{} |
Contributor
Author
There was a problem hiding this comment.
This will not work as previous block may still be in memory and pending being written to s3. So it's better to keep prevHash and try to match next time someones writes.
Contributor
VojtechVitek
left a comment
VojtechVitek
left a comment
There was a problem hiding this comment.
LGTM
One minor comment about the err propagation
| w.prevHash = common.Hash{} | ||
| return fmt.Errorf("parent hash mismatch, expected %s, got %s", | ||
| w.prevHash.String(), b.Parent.String()) | ||
| return fmt.Errorf("%w, expected %s, got %s", ErrParentHashMismatch, b.Parent.String(), w.prevHash.String()) |
Contributor
There was a problem hiding this comment.
Wrapping like this probably won't work, since : %w must be the last argument as far as I recall.
You can use errors.Join(ErrParentHashMismatch, err) instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… been written