fix: double close on w.writeFile error #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VojtechVitek
approved these changes
Oct 22, 2025
writer.go
Outdated
Comment on lines
217
to
221
| recoverFileIndex := func() { | ||
| // remove last file from file index as it's not written | ||
| files := w.fileIndex.Files()[:len(w.fileIndex.Files())-1] | ||
| w.fileIndex = NewFileIndexFromFiles(w.fs, files) | ||
| } |
Contributor
There was a problem hiding this comment.
I think you could really defer it on error:
defer func () {
if err != nil {
// remove last file from file index as it's not written
files := w.fileIndex.Files()[:len(w.fileIndex.Files())-1]
w.fileIndex = NewFileIndexFromFiles(w.fs, files)
}
}()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.