Add immutable wallet proxy hook #632
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ScreamingHawk
commented
Dec 19, 2024
| ]), | ||
| gasLimit: 50000, // Expected ~28k gas. Buffer added | ||
| delegateCall: false, | ||
| revertOnError: false, |
Contributor
Author
There was a problem hiding this comment.
revertOnError: false, is intentional. We don't want a failure adding the hook to prevent whatever the user's intended transaction is.
Agusx1211
reviewed
Dec 20, 2024
packages/account/src/account.ts
Outdated
| to: this.address, | ||
| data: hooksInterface.encodeFunctionData(hooksInterface.getFunction('addHook')!, [ | ||
| '0x90611127', | ||
| '0x1f56dbAD5e8319F0DE9a323E24A31b5077dEB1a4' |
Member
There was a problem hiding this comment.
Lets move this hardcoded address somewhere else, maybe context.
Contributor
Author
There was a problem hiding this comment.
Updated. Now requires this change to wallet webapp to pass context: https://github.com/0xsequence/wallet-webapp/pull/807
ScreamingHawk
force-pushed
the
immutable-hook
branch
2 times, most recently
from
0190b94 to
5796b2a
Compare
Member
|
LGTM Now |
ScreamingHawk
force-pushed
the
immutable-hook
branch
from
5796b2a to
e9c6931
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires: 0xsequence/wallet-contracts#191
Immutable ERC721/1155s have an OperatorAllowlist that prevent contracts owning tokens. For wallets to own tokens they must have an approved bytecode and implementation address returned by a
PROXY_getImplementation()function.This PR adds the
PROXY_getImplementation()function to a wallet via the hooks module. This is added whenever the user interacts with an immutable chain. The hook is only added once.