-
Notifications
You must be signed in to change notification settings - Fork 17
Fix compatibility with latest devkitARM/libnds #61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
NitroTracker used to provide its own, faster version of dmaFillWords. Modern versions of libnds include the performance fix, making the duplication unnecessary.
ad9a4ff to
adae1fc
Compare
|
Some more fixes have been added:
Further (feature-heavier) work will probably happen on a separate branch. |
|
Features and tweaks beyond these (which are mostly bugfixes/optimization/cleanup, and DSi support) are currently being added to the "new" branch. |
|
Thanks a ton for all these fixes! I pulled 0xtob/libntxm#2 . Does this address the required fixes for this pull request? |
|
Absolutely. This PR matches the libntxm PR in this regard. Please note that the changes here cut off at a certain point - as I haven't received a response to the PR for a while, I got somewhat carried away and started developing a fork of my own with added functionality and deeper changes on the "asiekierka:new" branch (for both NitroTracker and libntxm), complete with an unofficial release and changelog made two days ago. I wanted to keep this branch solely for non-behaviour-changing fixes. As I have written a changelog and published a release, it should be possible to get a good idea of what the changes were and how they function in practice. It's worth discussing where we go from here. It would be nice to see all these changes become official, of course! EDIT: The release is here - I've also ensured that the contributors whose work I used consent to relicensing their patches to tobkit under Apache 2.0, so there's no problem here. |
Better DSi/3DS support! Some fixes in libntxm are also required (to improve SD card performance and stability, particularly on the DSi where it will crash/load very slowly otherwise) - but as of right now, the GitHub repository is behind the Google Code archive, so I'd like to know if I should wait until you update the GitHub with the latest code (either by pulling in chee's update, or by re-importing the repository with full history preserved) to push my fixes.
FreeMem=15943680byteFixed microphone support requires 0xtob/libntxm#2