Skip to content

Conversation

@asiekierka
Copy link

@asiekierka asiekierka commented Jun 27, 2020

Better DSi/3DS support! Some fixes in libntxm are also required (to improve SD card performance and stability, particularly on the DSi where it will crash/load very slowly otherwise) - but as of right now, the GitHub repository is behind the Google Code archive, so I'd like to know if I should wait until you update the GitHub with the latest code (either by pulling in chee's update, or by re-importing the repository with full history preserved) to push my fixes.

FreeMem=15943680byte

Fixed microphone support requires 0xtob/libntxm#2

NitroTracker used to provide its own, faster version of dmaFillWords.
Modern versions of libnds include the performance fix, making the
duplication unnecessary.
@asiekierka asiekierka force-pushed the master branch 2 times, most recently from ad9a4ff to adae1fc Compare July 4, 2020 13:56
@asiekierka
Copy link
Author

asiekierka commented Jul 4, 2020

Some more fixes have been added:

  • memory leak fixes, particularly in edge case scenarios (I did not worry myself as much with program-unload memory leaks, as we are not running under an operating system here), primarily found in fincs's FeOS port of NitroTracker,
  • minor drawing/UI performance improvements.

Further (feature-heavier) work will probably happen on a separate branch.

@asiekierka
Copy link
Author

Features and tweaks beyond these (which are mostly bugfixes/optimization/cleanup, and DSi support) are currently being added to the "new" branch.

@0xtob
Copy link
Owner

0xtob commented Jul 11, 2020

Thanks a ton for all these fixes! I pulled 0xtob/libntxm#2 . Does this address the required fixes for this pull request?

@asiekierka
Copy link
Author

asiekierka commented Jul 11, 2020

Absolutely. This PR matches the libntxm PR in this regard.

Please note that the changes here cut off at a certain point - as I haven't received a response to the PR for a while, I got somewhat carried away and started developing a fork of my own with added functionality and deeper changes on the "asiekierka:new" branch (for both NitroTracker and libntxm), complete with an unofficial release and changelog made two days ago. I wanted to keep this branch solely for non-behaviour-changing fixes.

As I have written a changelog and published a release, it should be possible to get a good idea of what the changes were and how they function in practice.

It's worth discussing where we go from here. It would be nice to see all these changes become official, of course!

EDIT: The release is here - I've also ensured that the contributors whose work I used consent to relicensing their patches to tobkit under Apache 2.0, so there's no problem here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants