Fix type errors for Luau New Type Solver #208
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR fixes type errors detected by the Luau New Type Solver by adding explicit type casts and removing unnecessary type annotations. The changes ensure compatibility with the new type solver while maintaining backward compatibility with the existing type solver.
Changes:
- Removed unnecessary
:: anytype cast indebug.tracebackcall in Janitor.lua - Added explicit type cast for ModuleScript in Themes/init.lua to satisfy type checker
- Fixed trailing newline formatting in both files
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Packages/Janitor.lua | Removed redundant :: any cast from debug.traceback call |
| src/Features/Themes/init.lua | Added explicit type cast for ModuleScript before requiring it |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes type errors for TopbarPlus that are shown when the Luau New Type Solver beta is enabled.
This PR has been tested with the Luau New Type Solver enabled and disabled. With the Luau New Type Solver disabled, no new warnings are produced. This PR just solves warnings with the Luau New Type Solver enabled.
Script Analysis Before
Script Analysis After