Skip to content

Conversation

@wcassels
Copy link
Contributor

@wcassels wcassels commented Aug 9, 2025

Fixes #192

I tested on commits before 74ece6a that copying from Chrome/snipping tool/Discord/a few more still work, and that copying from Paint/Firefox works too (with transparent backgrounds filled in with black).

I then tested on the PNG-supporting commit that everything still works, with additional support for transparency from Firefox

Aside: this doesn't feel like the perfect solution. Hypothetically, we could see a bitmap with bitCount = 32, compression = BI_RGB, non-zero alpha mask, and nonsense/zero bytes in the alpha channel that upstream (who's following the spec strictly) wants us to ignore; I think this PR breaks support for cases like this (when PNG's unavailable). But I think supporting copying from firefox/paint makes this a clear improvement, and the tests I added make it easy to iterate safely if/when the next person runs into these issues :)

@complexspaces complexspaces added bug Something isn't working O-Windows Work related to the clipboard on Windows. waiting on review The change is currently waiting on an arboard maintainer for a review or larger-scale update labels Aug 13, 2025
@complexspaces complexspaces added waiting on author Further information is requested and removed waiting on review The change is currently waiting on an arboard maintainer for a review or larger-scale update labels Aug 13, 2025
@wcassels
Copy link
Contributor Author

Also rebased on master to fix the merge conflicts.

@complexspaces complexspaces added waiting on review The change is currently waiting on an arboard maintainer for a review or larger-scale update and removed waiting on author Further information is requested labels Aug 15, 2025
Copy link
Member

@complexspaces complexspaces left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems good to me now, thanks again for the PR and I doubly appreciate the added test cases.

I was curious if this affected #122 but it seems like its the same regardless of this change. I'll have to continue investigating what's going on there later... EDIT: Nevermind, my brain got two things mixed up here.

@complexspaces complexspaces merged commit 55c0b26 into 1Password:master Aug 21, 2025
11 checks passed
@wcassels
Copy link
Contributor Author

Great 🎊 thanks for your help too. Do you usually stick to a regular release schedule? Would be great to move my arboard dependencies back to the crates.io version.

@complexspaces
Copy link
Member

I don't have a documented schedule for releases. I usually just release once enough has changed or someone asks. Between this and the file_list PR I'll probably try and release something Saturday.

@complexspaces
Copy link
Member

This is now released in v3.6.1 on crates.io.

Thank you very much, again, for all the investigation and testing you did before and during this PR, and the collaborative effort. It made landing such a complicated/fragile change a lot easier for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working O-Windows Work related to the clipboard on Windows. waiting on review The change is currently waiting on an arboard maintainer for a review or larger-scale update

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Consider switching to retrieving PNG on Windows

2 participants