Use a more flexible way to detect extensions path (**+ Windows suuport, maybe**) #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Hi @oni305 , @305engineering, could you please review this PR? |
Author
|
@oni305, @305engineering, could you please review and merge this PR when you have a chance? |
1 similar comment
Author
|
@oni305, @305engineering, could you please review and merge this PR when you have a chance? |
rktech-de
added a commit
to rktech-de/Inkscape-to-Laser-GCode
that referenced
this pull request
Jan 10, 2022
ghost
approved these changes
Jan 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @oni305, these changes not only make this script workable in terms of a custom extensions' path usage on *nix, but also, I believe, they are moving the script a little bit closer to some multi-platform usage :-)