Skip to content

Fix/rooferpy pwh #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Ylannl merged 6 commits into from
Dec 3, 2025
Merged

Fix/rooferpy pwh #143

Ylannl merged 6 commits into from
Dec 3, 2025

Conversation

@ipadjen
Copy link
Collaborator

@ipadjen ipadjen commented Nov 29, 2025

Fixes #136

@ipadjen ipadjen mentioned this pull request Nov 29, 2025
Closed
@ipadjen
Copy link
Collaborator Author

ipadjen commented Nov 29, 2025

Docker build failing with this message:

2316.1 /opt/roofer/src/extra/io/VectorReaderOGR.cpp:215:65: error: invalid conversion from 'const OGRSpatialReference*' to 'OGRSpatialReference*' [-fpermissive]
2316.1 215 | if (OGRSpatialReference* layerSRS = poLayer->GetSpatialRef()) {
2316.1 | ~~~~~~~~~~~~~~~~~~~~~~^~
2316.1 | |
2316.1 | const OGRSpatialReference*

Seen this already in City4CFD: tudelft3d/City4CFD@3665268

@ipadjen ipadjen requested a review from Ylannl November 29, 2025 22:57
@Ylannl Ylannl merged commit c9f272f into develop Dec 3, 2025
6 checks passed
@Ylannl Ylannl mentioned this pull request Dec 3, 2025
Closed
@ipadjen ipadjen deleted the fix/rooferpy_pwh branch December 15, 2025 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Ylannl Ylannl Awaiting requested review from Ylannl

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ipadjen @Ylannl