Port to netcore 2.0 #28
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
I'm going to assume this project is abandoned. I'll probably make my own fork and distribute an updated nuget package at some later date. Probably when I have some free time in December. Let me know if you'd rather I not do that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've ported your project to netcore 2.0.
I took the opportunity to upgrade your nunit to v3 as well. All tests seem to pass.
I generated a new nuget package as well (putting it in the usual folder). I wasn't sure about your custom NuGet scripts, so I left those in just in case they were needed.
Please review at your leisure. I really like this library and look forward to being able to use it with other netstandard 2.0 code (without warnings) 😄
Cheers.