Skip character when moving to start of paragraph with selectionBehavior character #410
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgdhs27
force-pushed
the
character-skip
branch
from
4194858 to
d2c97f4
Compare
jgdhs27
commented
Sep 27, 2025
| return Selections.shift(selection, shiftTo, shift, _); | ||
| return Selections.shift(selection, shiftTo, shift, _, skipCharacter); | ||
| }); | ||
| } else if (where === "end") { |
Contributor
Author
There was a problem hiding this comment.
to fix the issue with "next paragraph", you'd have to find the condition for which to set skipCharacter in the where === "end" branch too. i haven't been able to figure out the right condition.
jgdhs27
force-pushed
the
character-skip
branch
from
d2c97f4 to
918eec9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes moving to the previous paragraph with selectionBehavior character, as described in #408.
Too see what this does, create a text file with a few parargaphs like
and use goto previous paragraph.
Before:
After:
This partially resolves #408. There's a similar issue when moving to the next paragraph, although it's far less severe in that case, as it only results in selecting extra whitespace. (Honestly, the precise behavior for moving paragraphs in helix is pretty difficult to understand.)